Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] rename gitpod extensions #5353

Merged
merged 1 commit into from
Aug 26, 2021
Merged

[code] rename gitpod extensions #5353

merged 1 commit into from
Aug 26, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Aug 24, 2021

  • /werft with-clean-slate-deployment

What it does

It reduces amount of extensions which we publish to VS Code marketplace to 2:

  • Gitpod runs locally
  • Gitpod Remote runs in remote workspace
How to test

It does not do any significant changes for web version, but still there are some build script changes, so smoke testing is required:

@akosyakov
Copy link
Member Author

akosyakov commented Aug 26, 2021

/werft run

👍 started the job as gitpod-build-ak-code-ext-rename.2

@akosyakov akosyakov force-pushed the ak/code_ext_rename branch 2 times, most recently from 436556f to f38cb5f Compare August 26, 2021 11:04
@akosyakov akosyakov marked this pull request as ready for review August 26, 2021 11:50
@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 26, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: a6a388f9a5ef0b6a4f072cface9fba14b7f84628

@akosyakov
Copy link
Member Author

akosyakov commented Aug 26, 2021

/werft run

👍 started the job as gitpod-build-ak-code-ext-rename.6

@akosyakov
Copy link
Member Author

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, JanKoehnlein

Associated issue requirement bypassed by: akosyakov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 498cd69 into main Aug 26, 2021
@roboquat roboquat deleted the ak/code_ext_rename branch August 26, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants