Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Don't try to re-set same quota #5340

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Aug 24, 2021

We must not set the CFS quota when that same quota is already in place. If we do so, we'll incur an error where there is none.

fixes #5326

How to review

  1. Start a workspace
  2. Verify that ws-daemon does not spew error messages to the tune of "cannot set CFS quota"

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #5340 (aede365) into main (84c6c68) will increase coverage by 23.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5340       +/-   ##
=========================================
+ Coverage      0   23.21%   +23.21%     
=========================================
  Files         0       11       +11     
  Lines         0     1930     +1930     
=========================================
+ Hits          0      448      +448     
- Misses        0     1423     +1423     
- Partials      0       59       +59     
Flag Coverage Δ
components-ws-daemon-app 23.21% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/resources/controller.go 33.69% <100.00%> (ø)
components/ws-daemon/pkg/content/archive.go 59.34% <0.00%> (ø)
components/ws-daemon/pkg/content/tar.go 46.71% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/resources/dispatch.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/internal/session/store.go 19.38% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
components/ws-daemon/pkg/quota/size.go 87.30% <0.00%> (ø)
components/ws-daemon/pkg/content/initializer.go 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c6c68...aede365. Read the comment docs.

@csweichel csweichel marked this pull request as ready for review August 24, 2021 07:47
@aledbf
Copy link
Member

aledbf commented Aug 24, 2021

/lgtm
/approve

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: feed183279d545794b709f9851b2c4a63a4ee65a

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

Associated issue: #5326

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 4d96c95 into main Aug 24, 2021
@roboquat roboquat deleted the csweichel/ws-daemon-cannot-set-5326 branch August 24, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ws-daemon] "cannot set new CPU limit"
3 participants