Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager-bridge] Sync node grpc options with go counterpart #5322

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 23, 2021

No description provided.

@geropl
Copy link
Member

geropl commented Aug 23, 2021

Do the changes fit to this recommendation of one of the authors of grpc-node?

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess they should be similar to these values, right?

grpcOpts := []grpc.DialOption{
grpc.WithBlock(),
grpc.WithBackoffMaxDelay(5 * time.Second),
grpc.WithKeepaliveParams(keepalive.ClientParameters{
Time: 5 * time.Second,
Timeout: time.Second,
PermitWithoutStream: true,
}),
}

Then it looks good so far.

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d111dc9efb8b07a2a15730916199046be23f1ede

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seeing this comment of Gero:

#5322 (comment)

@aledbf
Copy link
Member Author

aledbf commented Aug 23, 2021

@corneliusludmann yes, I am trying to reuse what we are using in Go
cc @geropl

@corneliusludmann
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 23, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d111dc9efb8b07a2a15730916199046be23f1ede

@corneliusludmann
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusludmann

Associated issue requirement bypassed by: corneliusludmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 1545241 into main Aug 23, 2021
@roboquat roboquat deleted the aledbf/bridgeopts branch August 23, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants