-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-manager-bridge] Sync node grpc options with go counterpart #5322
Conversation
Do the changes fit to this recommendation of one of the authors of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess they should be similar to these values, right?
gitpod/components/ee/ws-scheduler/pkg/scaler/driver.go
Lines 82 to 90 in 6ab9ee1
grpcOpts := []grpc.DialOption{ | |
grpc.WithBlock(), | |
grpc.WithBackoffMaxDelay(5 * time.Second), | |
grpc.WithKeepaliveParams(keepalive.ClientParameters{ | |
Time: 5 * time.Second, | |
Timeout: time.Second, | |
PermitWithoutStream: true, | |
}), | |
} |
Then it looks good so far.
LGTM label has been added. Git tree hash: d111dc9efb8b07a2a15730916199046be23f1ede
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just seeing this comment of Gero:
@corneliusludmann yes, I am trying to reuse what we are using in Go |
/lgtm |
LGTM label has been added. Git tree hash: d111dc9efb8b07a2a15730916199046be23f1ede
|
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: corneliusludmann Associated issue requirement bypassed by: corneliusludmann The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.