Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wrapping for contextUrl #5248

Merged
merged 1 commit into from
Aug 18, 2021
Merged

feat: add wrapping for contextUrl #5248

merged 1 commit into from
Aug 18, 2021

Conversation

Cahllagerfeld
Copy link

closes #4556

  • added truncate className
  • added title attribute

@Cahllagerfeld
Copy link
Author

Unfortunately I wasn't able to test it locally.
I didnt manage to get the dashbaord running locally/ in gitpod due to an error regarding wss :(

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 18, 2021

/werft run

👍 started the job as gitpod-build-cahllagerfeld-issue-4556--url-wrapping.0

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 18, 2021

Hey @Cahllagerfeld! Thanks for contributing! 🧡

Changes look good so far. ✔️

I've triggered the preview environment in #5248 (comment), should be up and running in a few minutes. 👀

@Cahllagerfeld
Copy link
Author

Thats awesome! :D

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX looks good! 🌟

@jankeromnes could you take a look when you are free and merge this?

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4955d35bffde5d4d4076d7d0c8cd18c71bf39114

@gtsiolis gtsiolis requested review from jankeromnes and removed request for corneliusludmann August 18, 2021 08:06
@jankeromnes
Copy link
Contributor

jankeromnes commented Aug 18, 2021

Many thanks for this contribution @Cahllagerfeld! 🎉

This is already reviewed and approved, so I'm just "rubberstamping" 😁 🚀

/approve

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtsiolis, jankeromnes

Associated issue: #4556

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jankeromnes jankeromnes removed their request for review August 18, 2021 08:37
@roboquat roboquat merged commit 47a0bb0 into gitpod-io:main Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dashboard] text wrapping on "workspace is already running" dialog
4 participants