-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add wrapping for contextUrl #5248
feat: add wrapping for contextUrl #5248
Conversation
Unfortunately I wasn't able to test it locally. |
/werft run 👍 started the job as gitpod-build-cahllagerfeld-issue-4556--url-wrapping.0 |
Hey @Cahllagerfeld! Thanks for contributing! 🧡 Changes look good so far. ✔️ I've triggered the preview environment in #5248 (comment), should be up and running in a few minutes. 👀 |
Thats awesome! :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX looks good! 🌟
@jankeromnes could you take a look when you are free and merge this?
LGTM label has been added. Git tree hash: 4955d35bffde5d4d4076d7d0c8cd18c71bf39114
|
Many thanks for this contribution @Cahllagerfeld! 🎉 This is already reviewed and approved, so I'm just "rubberstamping" 😁 🚀 /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gtsiolis, jankeromnes Associated issue: #4556 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
closes #4556
truncate
classNametitle
attribute