[analytics] group rendered events by session #5220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
requested review from
jakobhero
and removed request for
csweichel and
geropl
akosyakov
force-pushed
the
ak/rendered_by_session
branch
from
5806e81 to
968dde3
Compare
|
/werft run 👍 started the job as gitpod-build-ak-rendered-by-session.5 |
|
/werft run 👍 started the job as gitpod-build-ak-rendered-by-session.6 |
jakobhero
approved these changes
Aug 17, 2021
|
LGTM label has been added. Git tree hash: 566e5489aaaa1ad8e494e12e1806fe81a73b0e90
|
|
/assign @csweichel |
|
/approve no-issue |
1 similar comment
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akosyakov, jakobhero, JanKoehnlein Associated issue requirement bypassed by: akosyakov, JanKoehnlein The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More analytics to track down #5220
We need to group events by window session id, workspace and instance ids are not helpful because there can be multiple windows for the same instance and reloading the page bring a lot of confusion to data.