open task terminal in correct workspace location

[akosyakov]

What it does

• fix Terminal does not open in the correct workspaceLocation  #4935

How to test

• Without workspace location: https://akosyakov-terminal-does-not-open-4935.staging.gitpod-dev.com#https://github.com/akosyakov/parcel-demo
  • In this case we fall back to checkoutLocation.
• Workspace location as file: https://akosyakov-terminal-does-not-open-4935.staging.gitpod-dev.com#https://github.com/gitpod-io/gitpod
  • In this case we fall back to checkoutLocation too.
• Workspace location as dir: https://akosyakov-terminal-does-not-open-4935.staging.gitpod-dev.com#https://github.com/redwoodjs/redwood
  • In this case workspaceLocation should be used but only for task terminals, regular terminals (new created by VS Code) not under our control

[codecov]

Codecov Report

Merging #5218 (c8fefd5) into main (447dd3b) will increase coverage by 37.59%.
The diff coverage is 37.50%.

@@            Coverage Diff            @@
##           main    #5218       +/-   ##
=========================================
+ Coverage      0   37.59%   +37.59%     
=========================================
  Files         0       16       +16     
  Lines         0     4099     +4099     
=========================================
+ Hits          0     1541     +1541     
- Misses        0     2433     +2433     
- Partials      0      125      +125     

Flag	Coverage Δ
components-supervisor-app	37.59% <37.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/supervisor/pkg/supervisor/supervisor.go	6.41% <0.00%> (ø)
components/supervisor/pkg/terminal/service.go	32.38% <100.00%> (ø)
components/supervisor/pkg/terminal/ring-buffer.go	45.65% <0.00%> (ø)
components/supervisor/pkg/supervisor/services.go	25.50% <0.00%> (ø)
components/supervisor/pkg/ports/ports-config.go	79.85% <0.00%> (ø)
components/supervisor/pkg/supervisor/config.go	4.51% <0.00%> (ø)
...mponents/supervisor/pkg/supervisor/notification.go	83.95% <0.00%> (ø)
components/supervisor/pkg/supervisor/tasks.go	55.22% <0.00%> (ø)
components/supervisor/pkg/ports/served-ports.go	76.00% <0.00%> (ø)
components/supervisor/pkg/terminal/terminal.go	64.19% <0.00%> (ø)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 447dd3b...c8fefd5. Read the comment docs.

[JanKoehnlein]

/lgtm

[roboquat]

LGTM label has been added.

Git tree hash: 1bc167f7350069b5608df14628a100f387bd70e1

[akosyakov]

/approve

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, JanKoehnlein

Associated issue: #4935

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/supervisor/OWNERS [akosyakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment