-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] Add George as a dashboard OWNER #5192
Conversation
Lol, I approve my own PR! /approve no-issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jankeromnes! π§‘
β¬οΈ For more context in case anyone reads this, I can still approve changes but @roboquat won't allow merging these PRs without an extra approval from someone from the engineering team (see engineering-meta
). We could merge this if this could help us move faster and better as a team, especially since we currently have basic triage operations and code review workflows. π€
π¨ If we merge this I may have to be a bit more frugal with PR approvals and loop in others when a deeper dive into the code changes is needed as well as make good use of labels like do-not-merge/hold
. π€
β¬οΈ However, I'm also fine with not being part of the approvers as most of the times we'll also need a review from someone else who can take a deeper dive into the code changes besides the ones affecting the visual aspect of the changes. ποΈ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course!
LGTM label has been added. Git tree hash: c033eba33f4b8597054182d86809278916d24921
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jankeromnes, svenefftinge Associated issue requirement bypassed by: jankeromnes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the consistently outstanding PRs and code reviews @gtsiolis! ποΈ π―
I don't see why @roboquat won't let you approve dashboard Pull Requests. I vote more power to you! π π
(Alternatively, we could create a
ux
orproduct
team in https://github.com/gitpod-io/gitpod/blob/main/OWNERS_ALIASES, but we can also do that later.)