Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Update runc to v1.0.1 #5190

Merged
merged 1 commit into from
Sep 10, 2021
Merged

[ws-daemon] Update runc to v1.0.1 #5190

merged 1 commit into from
Sep 10, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 13, 2021

No description provided.

@aledbf
Copy link
Member Author

aledbf commented Aug 13, 2021

/assign @csweichel

@aledbf
Copy link
Member Author

aledbf commented Aug 13, 2021

/hold

@aledbf aledbf marked this pull request as ready for review August 13, 2021 14:40
@csweichel
Copy link
Contributor

csweichel commented Sep 6, 2021

/werft run

👍 started the job as gitpod-build-aledbf-runc.1

@csweichel
Copy link
Contributor

csweichel commented Sep 6, 2021

/werft run

👍 started the job as gitpod-build-aledbf-runc.2

@aledbf
Copy link
Member Author

aledbf commented Sep 7, 2021

/werft run

👍 started the job as gitpod-build-aledbf-runc.3

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #5190 (ad1c41c) into main (6f6f85d) will decrease coverage by 12.16%.
The diff coverage is n/a.

❗ Current head ad1c41c differs from pull request most recent head 5b2cb93. Consider uploading reports for the commit 5b2cb93 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main   #5190       +/-   ##
==========================================
- Coverage   19.39%   7.22%   -12.17%     
==========================================
  Files           2       3        +1     
  Lines         165     609      +444     
==========================================
+ Hits           32      44       +12     
- Misses        131     562      +431     
- Partials        2       3        +1     
Flag Coverage Δ
components-local-app-app-linux ?
components-local-app-app-windows ?
components-workspacekit-app 7.22% <ø> (?)
components-ws-daemon-nsinsider-app ∅ <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/workspacekit/cmd/rings.go 7.10% <0.00%> (ø)
components/workspacekit/cmd/root.go 0.00% <0.00%> (ø)
components/workspacekit/cmd/lift.go 18.18% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f6f85d...5b2cb93. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Sep 10, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 99920eba45973bca5b2bac89ef50538bdfaa6de7

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit a7d27b6 into main Sep 10, 2021
@roboquat roboquat deleted the aledbf/runc branch September 10, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants