Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(install): retire broken gcp-terraform #5144

Merged
merged 1 commit into from
Sep 1, 2021
Merged

chore(install): retire broken gcp-terraform #5144

merged 1 commit into from
Sep 1, 2021

Conversation

ghuntley
Copy link
Contributor

@ghuntley ghuntley commented Aug 11, 2021

Establishes a single source of truth. Head to https://www.gitpod.io/docs/self-hosted/latest/installation instead for instructions how to use Gitpod with GCP.

I'm all for a /install/ folder but currently it leads people down the wrong path because the contents are not supported/maintained.

@ghuntley ghuntley added the component: install Terraform installation scripts, helm charts, installer images label Aug 11, 2021
@roboquat roboquat requested a review from fntlnz August 11, 2021 05:45
@ghuntley
Copy link
Contributor Author

/assign @corneliusludmann

@corneliusludmann
Copy link
Contributor

I'm fine with removing the gcp-terraform folder. And indeed, as far as I know, nobody maintains this. What is your thought on this @geropl?

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I thought we already removed this, like, multiple times.
Let's try another time! 😉

@roboquat
Copy link
Contributor

roboquat commented Sep 1, 2021

LGTM label has been added.

Git tree hash: 207a5efba529bc2673492127ee175d30fbadf987

@gitpod-io gitpod-io deleted a comment from roboquat Sep 1, 2021
@geropl
Copy link
Member

geropl commented Sep 1, 2021

/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl

Associated issue requirement bypassed by: geropl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 208eb3c into main Sep 1, 2021
@roboquat roboquat deleted the gh/install branch September 1, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component: install Terraform installation scripts, helm charts, installer images size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants