[ws-daemon] Re-establish IWS on restart #5130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5079
ws-daemon provides an in-workspace service (IWS) to workspacekit. We use this IWS to establish the UID/GID mapping, mount proc and sysfs, prepare the rootfs and unmount it all on shutdown. If the IWS is not available, the workspace does not function well. Prior to this change, ws-daemon would not re-establish the IWS for already running workspaces due to a missing call in the lifecycle hooks.
How to test
docker run --rm -it alpine:latest
in the workspace. The container should just run and not complain about procfs.