Mention username who added project in a team #5128

gtsiolis · 2021-08-09T21:31:48Z

What does this PR do?

This is using the existing structure for indicating already imported projects instead of the tooltip shown in the issue description, see #5119.

Change the repository name color when it's not available to import.
Add a placeholder for inserting the user who already added a project.

Fix #5119.

BEFORE	AFTER

components/dashboard/src/projects/NewProject.tsx

jankeromnes

Many thanks! This looks like a good first pass to me 👍 I'm just a little worried about how convoluted our initial Teams & Projects code already is (re: multiple components variously enriching data one after the other).

I think a good approach to fix this would be to introduce good profiling, then identify which Teams & Projects features have the worst performance/UX impact (e.g. "fetching the list of repos is too slow"), and optimize these code paths in priority.

components/dashboard/src/projects/NewProject.tsx

components/gitpod-protocol/src/gitpod-service.ts

components/server/ee/src/workspace/gitpod-server-impl.ts

jankeromnes · 2021-08-12T08:03:53Z

components/server/ee/src/workspace/gitpod-server-impl.ts

+                    const owner = await this.userDB.findUserById(ownerId);
+                    if (owner) {
+                        repo.inUse = {
+                            userId : owner.id,
+                            userName: owner?.name || owner?.fullName || 'somebody'
+                        }
+                    }


This entire for loop seems to add a few more DB queries to a code path that is already super slow (we already make users wait long seconds before showing anything in the UI).

I think this could possibly be optimized by refactoring projectsService.getProjectsByCloneUrls (only used here I believe), and making that method fetch & process everything required in one go, as opposed to multiple components variously enriching data one after the other.

However, please feel free to add this as a TODO comment in the code.

fully agree to this argument. it should be feasible to compute in db query.

roboquat · 2021-08-12T08:06:36Z

LGTM label has been added.

Git tree hash: 298a3f517afcec1020e90c337f1a359fdbfd3fb4

gtsiolis · 2021-08-12T14:05:24Z

~~Adding a few comments using github.dev.~~

gtsiolis

Adding a few comments using github.dev.

components/dashboard/src/projects/NewProject.tsx

components/gitpod-protocol/src/gitpod-service.ts

stale · 2021-09-28T10:59:39Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gtsiolis · 2021-10-20T15:02:35Z

Re-opening for now as it could be still relevant. Cc @jldec

stale · 2021-10-30T17:22:18Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

AlexTugarev · 2021-12-17T09:09:39Z

/werft run

👍 started the job as gitpod-build-gt-mention-user-who-added-project.13

AlexTugarev · 2021-12-17T13:27:21Z

Thanks @laushinka for catching issue and helping testing!
We've just updated to fix an issue with project created in personal accounts. It should work now 👍🏻

laushinka · 2021-12-17T13:28:08Z

/assign

jldec

Looks good - thank you @AlexTugarev @laushinka @gtsiolis and team.

jldec · 2021-12-17T17:32:50Z

components/dashboard/src/projects/NewProject.tsx

                                            {!r.inUse ? (
                                                <button className="primary" onClick={() => setSelectedRepo(r)}>Select</button>
                                            ) : (
-                                                <p className="my-auto">already taken</p>
+                                                <p className="text-gray-500 font-medium">
+                                                    @{r.inUse.userName} already<br/>added this repo


Mentioning here for reference - No need to implement before merging this PR:
While I was testing today, I discovered a stronger reason for doing as @gtsiolis suggested. Users with multiple integrations will be shown using the user-id of the first signup, which is not necessarily the user-id for the integration of the repo in question. E.g I used a different username for GitHub vs. GitLab and the "already added" message is showing my GitHub userid even though the repo is on GitLab.

roboquat · 2021-12-17T17:35:37Z

LGTM label has been added.

Git tree hash: 52f8e2bd42b68b02c09ae92dc38aa3580046d699

laushinka · 2021-12-17T23:57:31Z

/werft run

👍 started the job as gitpod-build-gt-mention-user-who-added-project.16

laushinka · 2021-12-19T10:03:40Z

/werft run

👍 started the job as gitpod-build-gt-mention-user-who-added-project.17

Co-authored-by: George Tsiolis <[email protected]> Co-authored-by: Laurie T. Malau <[email protected]> Co-authored-by: Alex Tugarev <[email protected]>

laushinka · 2021-12-19T10:34:21Z

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-gt-mention-user-who-added-project.19

laushinka · 2021-12-19T10:48:21Z

@jldec The builds were failing but turns out with-clean-slate-deployment did the trick. You can lgtm again 🙏🏽 The push I did was just a rebase.

jldec · 2021-12-20T07:53:52Z

/lgtm

roboquat · 2021-12-20T07:53:55Z

LGTM label has been added.

Git tree hash: 8e0fa246a36ccfc39e1d4c55f2c727a050a282ab

roboquat · 2021-12-20T07:53:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Foge9627, jankeromnes, jldec

Associated issue: #5119

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/dashboard/OWNERS~~ [jankeromnes,jldec]
~~components/gitpod-db/OWNERS~~ [jankeromnes,jldec]
~~components/gitpod-protocol/OWNERS~~ [jankeromnes,jldec]
~~components/server/OWNERS~~ [jankeromnes,jldec]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gtsiolis added component: dashboard 🧑‍🚀 crew: teams and projects labels Aug 9, 2021

roboquat requested a review from svenefftinge August 9, 2021 21:31

roboquat added the size/XS label Aug 9, 2021

gtsiolis commented Aug 9, 2021

View reviewed changes

components/dashboard/src/projects/NewProject.tsx Outdated Show resolved Hide resolved

gtsiolis removed the request for review from svenefftinge August 9, 2021 21:32

gtsiolis added the do-not-merge/hold label Aug 9, 2021

roboquat added size/M and removed size/XS labels Aug 11, 2021

svenefftinge force-pushed the gt/mention-user-who-added-project branch from 4120068 to 96d2ae2 Compare August 11, 2021 12:56

jankeromnes approved these changes Aug 12, 2021

View reviewed changes

roboquat assigned jankeromnes Aug 12, 2021

roboquat added the lgtm label Aug 12, 2021

roboquat added the approved label Aug 12, 2021

gtsiolis commented Aug 12, 2021

View reviewed changes

components/dashboard/src/projects/NewProject.tsx Show resolved Hide resolved

components/dashboard/src/projects/NewProject.tsx Outdated Show resolved Hide resolved

components/gitpod-protocol/src/gitpod-service.ts Outdated Show resolved Hide resolved

jankeromnes removed their assignment Sep 1, 2021

gtsiolis added feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. and removed 🧑‍🚀 crew: teams and projects labels Sep 14, 2021

stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 28, 2021

stale bot closed this Oct 3, 2021

gtsiolis reopened this Oct 20, 2021

stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Oct 20, 2021

roboquat added the team: webapp Issue belongs to the WebApp team label Oct 20, 2021

stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 30, 2021

JanKoehnlein removed the meta: stale This issue/PR is stale and will be closed soon label Nov 2, 2021

AlexTugarev force-pushed the gt/mention-user-who-added-project branch from e4b4d6f to 0c39e4b Compare December 17, 2021 13:25

roboquat assigned laushinka Dec 17, 2021

laushinka force-pushed the gt/mention-user-who-added-project branch from 0c39e4b to 04033cb Compare December 17, 2021 15:46

jldec approved these changes Dec 17, 2021

View reviewed changes

roboquat assigned jldec Dec 17, 2021

roboquat added the lgtm label Dec 17, 2021

Mention username who added project in a team

ed54059

Co-authored-by: George Tsiolis <[email protected]> Co-authored-by: Laurie T. Malau <[email protected]> Co-authored-by: Alex Tugarev <[email protected]>

laushinka force-pushed the gt/mention-user-who-added-project branch from 04033cb to ed54059 Compare December 19, 2021 10:14

roboquat removed the lgtm label Dec 19, 2021

roboquat added the lgtm label Dec 20, 2021

laushinka removed the do-not-merge/hold label Dec 20, 2021

roboquat merged commit 556c03c into main Dec 20, 2021

roboquat deleted the gt/mention-user-who-added-project branch December 20, 2021 08:16

This was referenced Dec 20, 2021

Link the username that added the project #7310

Closed

Link to user profile #7312

Merged

roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 21, 2021

gtsiolis mentioned this pull request Jan 24, 2022

Only one user can have a custom git integration #5411

Open

akosyakov mentioned this pull request Jul 31, 2023

[server/fga] centralize lookup of findUserById #18382

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mention username who added project in a team #5128

Mention username who added project in a team #5128

gtsiolis commented Aug 9, 2021 •

edited

Loading

jankeromnes left a comment •

edited

Loading

jankeromnes Aug 12, 2021

AlexTugarev Nov 2, 2021

roboquat commented Aug 12, 2021

gtsiolis commented Aug 12, 2021 •

edited

Loading

gtsiolis left a comment

stale bot commented Sep 28, 2021

gtsiolis commented Oct 20, 2021

stale bot commented Oct 30, 2021

AlexTugarev commented Dec 17, 2021 •

edited by werft-gitpod-dev-com bot

Loading

AlexTugarev commented Dec 17, 2021 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Dec 17, 2021

jldec left a comment •

edited

Loading

jldec Dec 17, 2021

roboquat commented Dec 17, 2021

laushinka commented Dec 17, 2021 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Dec 19, 2021 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Dec 19, 2021 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Dec 19, 2021 •

edited

Loading

jldec commented Dec 20, 2021

roboquat commented Dec 20, 2021

roboquat commented Dec 20, 2021

Mention username who added project in a team #5128

Mention username who added project in a team #5128

Conversation

gtsiolis commented Aug 9, 2021 • edited Loading

What does this PR do?

jankeromnes left a comment • edited Loading

Choose a reason for hiding this comment

jankeromnes Aug 12, 2021

Choose a reason for hiding this comment

AlexTugarev Nov 2, 2021

Choose a reason for hiding this comment

roboquat commented Aug 12, 2021

gtsiolis commented Aug 12, 2021 • edited Loading

gtsiolis left a comment

Choose a reason for hiding this comment

stale bot commented Sep 28, 2021

gtsiolis commented Oct 20, 2021

stale bot commented Oct 30, 2021

AlexTugarev commented Dec 17, 2021 • edited by werft-gitpod-dev-com bot Loading

AlexTugarev commented Dec 17, 2021 • edited by werft-gitpod-dev-com bot Loading

laushinka commented Dec 17, 2021

jldec left a comment • edited Loading

Choose a reason for hiding this comment

jldec Dec 17, 2021

Choose a reason for hiding this comment

roboquat commented Dec 17, 2021

laushinka commented Dec 17, 2021 • edited by werft-gitpod-dev-com bot Loading

laushinka commented Dec 19, 2021 • edited by werft-gitpod-dev-com bot Loading

laushinka commented Dec 19, 2021 • edited by werft-gitpod-dev-com bot Loading

laushinka commented Dec 19, 2021 • edited Loading

jldec commented Dec 20, 2021

roboquat commented Dec 20, 2021

roboquat commented Dec 20, 2021

gtsiolis commented Aug 9, 2021 •

edited

Loading

jankeromnes left a comment •

edited

Loading

gtsiolis commented Aug 12, 2021 •

edited

Loading

AlexTugarev commented Dec 17, 2021 •

edited by werft-gitpod-dev-com bot

Loading

AlexTugarev commented Dec 17, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jldec left a comment •

edited

Loading

laushinka commented Dec 17, 2021 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Dec 19, 2021 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Dec 19, 2021 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Dec 19, 2021 •

edited

Loading