Prebuild Events #5116

AlexTugarev · 2021-08-09T12:03:13Z

This PR includes

events on new prebuilds and updates of the Prebuilds page
storing of prebuild infos on prebuild creation instead of computing over and over again

/werft with-clean-slate-deployment

jankeromnes · 2021-08-13T13:16:01Z

Removing the automatic review request because this is still Draft. 😊

AlexTugarev · 2021-08-19T10:19:13Z

/werft run

👍 started the job as gitpod-build-at-prebuild-events.23

jankeromnes · 2021-08-25T08:00:46Z

/werft run

👍 started the job as gitpod-build-at-prebuild-events.36

jankeromnes · 2021-08-25T08:10:35Z

Error: create: failed to create: secrets "sh.helm.release.v1.gitpod.v1" is forbidden: unable to create new content in namespace staging-at-prebuild-events because it is being terminated

I guess the old namespace needs to be cleaned up first.

EDIT: This prebuild was stuck in Terminating for 9 hours:

$ kubectl get pods
NAME                                            READY   STATUS        RESTARTS   AGE
prebuild-aceac695-3de4-4e55-8bde-aab5e202f1b0   0/1     Terminating   0          9h

Fixed like so:

$ kubectl delete pod prebuild-aceac695-3de4-4e55-8bde-aab5e202f1b0 --force --grace-period 0
warning: Immediate deletion does not wait for confirmation that the running resource has been terminated. The resource may continue to run on the cluster indefinitely.
pod "prebuild-aceac695-3de4-4e55-8bde-aab5e202f1b0" force deleted

jankeromnes · 2021-08-25T08:19:13Z

/werft run

👍 started the job as gitpod-build-at-prebuild-events.37

gtsiolis

Seeing prebuilds pop-up on the Prebuilds list feels great! UX looks good! 🌟 🔝

roboquat · 2021-08-25T08:27:20Z

LGTM label has been added.

Git tree hash: 03a58e29a0ba7afe522c8bfc7fff93755a2a1fe1

jankeromnes

Many thanks @AlexTugarev! 👍

The UX also looks good to me (the Prebuilds page is so fast now! ⚡⚡ thank you so much for that)

I've left a few questions & suggestions in-line. Most notably, I think the events on "start prebuild" and on "start workspace"(!) should be triggered asynchronously, so as to:

Not make these important API calls slower with extra awaits
Not make these important API calls fail if triggering an event throws

/hold

components/dashboard/src/projects/Prebuilds.tsx

jankeromnes · 2021-08-25T09:34:56Z

components/dashboard/src/projects/Prebuild.tsx

@@ -52,7 +52,7 @@ export default function () {
        if (!prebuild) {


I did get to see a Prebuild with working logs, but for another Prebuild (for https://gitlab.com/gitpod-io/gitlab/-/merge_requests/1) I got this slightly worrying error:

Uncaught (in promise) Error: Request findPrebuilds failed with message: ER_PARSE_ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1

nice catch!

@jankeromnes, I've add a check to prevent it from hitting the db layer: https://github.com/gitpod-io/gitpod/pull/5116/files#diff-9c81815b0337b4e00a2ab1615cab6010a2497412f99dfc63c73a17f8bf28a90cR877

Can you invite me to that team please? I'd like to reproduce/verify the fix

It's on my user 😬 but please feel free to move it to a team by hacking the DB

@AlexTugarev I tried reproducing this bug, but I couldn't. Maybe that's a somewhat good sign? Although quite inconclusive, due to the problems on dev-staging / the partial deployment. 😅

I tried triggering new prebuilds, but they get lost in the "randomly-sorted 30-limited Prebuilds list" (the current deployment probably doesn't have the sort-order or creationTime fixes)

When trying the particular prebuild that failed, it now loads successfully, for what it's worth: https://at-prebuild-events.staging.gitpod-dev.com/projects/GitLab/d3b4628f-9649-4bef-8a86-01737fbf3ff8

components/gitpod-db/src/typeorm/entity/db-prebuild-info-entry.ts

components/gitpod-db/src/typeorm/workspace-db-impl.ts

components/server/ee/src/workspace/gitpod-server-impl.ts

components/server/ee/src/workspace/workspace-factory.ts

components/server/src/projects/projects-service.ts

jankeromnes · 2021-08-25T09:55:23Z

components/server/src/projects/projects-service.ts

+            const pbws = await this.workspaceDb.trace({}).findPrebuiltWorkspaceById(prebuildId);
+            const info = (await this.workspaceDb.trace({}).findPrebuildInfos([prebuildId]))[0];


Wouldn't it be cool to send an actual trace context here? (E.g. a few recently added methods in ProjectsService now take a TraceContext -- maybe findPrebuilds could too?)

👍🏻 for tracing. I

components/server/src/workspace/workspace-starter.ts

AlexTugarev · 2021-08-27T08:35:39Z

/werft run

👍 started the job as gitpod-build-at-prebuild-events.40

AlexTugarev · 2021-09-01T07:15:57Z

/approve no-issue

AlexTugarev · 2021-09-01T07:25:17Z

/hold cancel

svenefftinge · 2021-09-01T07:27:22Z

/lgtm

roboquat · 2021-09-01T07:27:25Z

LGTM label has been added.

Git tree hash: 1b9a810a8e32404584b4553fa3b110b91735739d

roboquat · 2021-09-01T07:27:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev, gtsiolis, jankeromnes, svenefftinge

Associated issue requirement bypassed by: AlexTugarev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/dashboard/OWNERS~~ [AlexTugarev,jankeromnes,svenefftinge]
~~components/ee/db-sync/OWNERS~~ [AlexTugarev,jankeromnes,svenefftinge]
~~components/gitpod-db/OWNERS~~ [AlexTugarev,jankeromnes,svenefftinge]
~~components/gitpod-protocol/OWNERS~~ [AlexTugarev,jankeromnes,svenefftinge]
~~components/server/OWNERS~~ [AlexTugarev,jankeromnes,svenefftinge]
~~components/ws-manager-bridge/OWNERS~~ [AlexTugarev,jankeromnes,svenefftinge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

AlexTugarev · 2021-09-01T07:27:48Z

Thanks @svenefftinge!

roboquat added the do-not-merge/work-in-progress label Aug 9, 2021

roboquat requested review from csweichel, jankeromnes, JanKoehnlein, laushinka and svenefftinge August 9, 2021 12:03

AlexTugarev removed request for svenefftinge, JanKoehnlein, jankeromnes, csweichel and laushinka August 9, 2021 12:03

roboquat added the size/XL label Aug 9, 2021

AlexTugarev requested a review from jankeromnes August 9, 2021 13:59

jankeromnes removed their request for review August 13, 2021 13:16

gtsiolis added the 🧑‍🚀 crew: teams and projects label Aug 16, 2021

AlexTugarev force-pushed the at/prebuild-events branch from 6ed7198 to 1e77cd6 Compare August 18, 2021 14:58

roboquat added size/XXL and removed size/XL labels Aug 18, 2021

AlexTugarev force-pushed the at/prebuild-events branch from df4319a to 52cd68b Compare August 19, 2021 09:32

AlexTugarev force-pushed the at/prebuild-events branch 2 times, most recently from f90bba1 to 8c84609 Compare August 20, 2021 08:33

roboquat added the do-not-merge/hold label Aug 20, 2021

AlexTugarev changed the title ~~WIP Prebuild Events~~ Prebuild Events Aug 20, 2021

AlexTugarev force-pushed the at/prebuild-events branch from dbc8215 to b2a1030 Compare August 24, 2021 11:56

roboquat added size/XL and removed size/XXL labels Aug 24, 2021

AlexTugarev force-pushed the at/prebuild-events branch from b2a1030 to abcdd2e Compare August 24, 2021 13:19

roboquat removed the size/XL label Aug 24, 2021

gtsiolis approved these changes Aug 25, 2021

View reviewed changes

roboquat assigned gtsiolis Aug 25, 2021

roboquat added the lgtm label Aug 25, 2021

jankeromnes approved these changes Aug 25, 2021

View reviewed changes

roboquat assigned jankeromnes Aug 25, 2021

AlexTugarev force-pushed the at/prebuild-events branch from 30fe0bf to 1e5b1e3 Compare August 25, 2021 10:36

roboquat removed the lgtm label Aug 25, 2021

AlexTugarev mentioned this pull request Aug 25, 2021

No feedback when triggering prebuilds #5374

Closed

AlexTugarev force-pushed the at/prebuild-events branch from 1e5b1e3 to d9e7296 Compare August 27, 2021 08:37

AlexTugarev added 2 commits September 1, 2021 06:43

[dashboard] add mocked server param to service.tsx

1b5ddcb

[projects] Add Prebuild Events

e62458b

AlexTugarev force-pushed the at/prebuild-events branch from d9e7296 to e62458b Compare September 1, 2021 06:47

[db-sync] remve debugger form spec

7edbf45

roboquat added the approved label Sep 1, 2021

AlexTugarev removed the do-not-merge/hold label Sep 1, 2021

roboquat assigned svenefftinge Sep 1, 2021

roboquat added the lgtm label Sep 1, 2021

roboquat merged commit 6bc80eb into main Sep 1, 2021

roboquat deleted the at/prebuild-events branch September 1, 2021 07:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prebuild Events #5116

Prebuild Events #5116

AlexTugarev commented Aug 9, 2021 •

edited

Loading

jankeromnes commented Aug 13, 2021 •

edited by werft-gitpod-dev-com bot

Loading

AlexTugarev commented Aug 19, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Aug 25, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Aug 25, 2021 •

edited

Loading

jankeromnes commented Aug 25, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment •

edited

Loading

roboquat commented Aug 25, 2021

jankeromnes left a comment

jankeromnes Aug 25, 2021

AlexTugarev Aug 25, 2021

AlexTugarev Aug 25, 2021

jankeromnes Aug 25, 2021

jankeromnes Aug 26, 2021

jankeromnes Aug 25, 2021

AlexTugarev Aug 25, 2021

AlexTugarev commented Aug 27, 2021 •

edited by werft-gitpod-dev-com bot

Loading

AlexTugarev commented Sep 1, 2021

AlexTugarev commented Sep 1, 2021

svenefftinge commented Sep 1, 2021

roboquat commented Sep 1, 2021

roboquat commented Sep 1, 2021

AlexTugarev commented Sep 1, 2021

		@@ -52,7 +52,7 @@ export default function () {
		if (!prebuild) {

		const pbws = await this.workspaceDb.trace({}).findPrebuiltWorkspaceById(prebuildId);
		const info = (await this.workspaceDb.trace({}).findPrebuildInfos([prebuildId]))[0];

Prebuild Events #5116

Prebuild Events #5116

Conversation

AlexTugarev commented Aug 9, 2021 • edited Loading

jankeromnes commented Aug 13, 2021 • edited by werft-gitpod-dev-com bot Loading

AlexTugarev commented Aug 19, 2021 • edited by werft-gitpod-dev-com bot Loading

jankeromnes commented Aug 25, 2021 • edited by werft-gitpod-dev-com bot Loading

jankeromnes commented Aug 25, 2021 • edited Loading

jankeromnes commented Aug 25, 2021 • edited by werft-gitpod-dev-com bot Loading

gtsiolis left a comment • edited Loading

Choose a reason for hiding this comment

roboquat commented Aug 25, 2021

jankeromnes left a comment

Choose a reason for hiding this comment

jankeromnes Aug 25, 2021

Choose a reason for hiding this comment

AlexTugarev Aug 25, 2021

Choose a reason for hiding this comment

AlexTugarev Aug 25, 2021

Choose a reason for hiding this comment

jankeromnes Aug 25, 2021

Choose a reason for hiding this comment

jankeromnes Aug 26, 2021

Choose a reason for hiding this comment

jankeromnes Aug 25, 2021

Choose a reason for hiding this comment

AlexTugarev Aug 25, 2021

Choose a reason for hiding this comment

AlexTugarev commented Aug 27, 2021 • edited by werft-gitpod-dev-com bot Loading

AlexTugarev commented Sep 1, 2021

AlexTugarev commented Sep 1, 2021

svenefftinge commented Sep 1, 2021

roboquat commented Sep 1, 2021

roboquat commented Sep 1, 2021

AlexTugarev commented Sep 1, 2021

AlexTugarev commented Aug 9, 2021 •

edited

Loading

jankeromnes commented Aug 13, 2021 •

edited by werft-gitpod-dev-com bot

Loading

AlexTugarev commented Aug 19, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Aug 25, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Aug 25, 2021 •

edited

Loading

jankeromnes commented Aug 25, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment •

edited

Loading

AlexTugarev commented Aug 27, 2021 •

edited by werft-gitpod-dev-com bot

Loading