Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisor] fix #5104: don't truncate env values after = char #5108

Merged
merged 2 commits into from
Aug 8, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Aug 8, 2021

What it does

How to test

  • Start a workspace for this repo and check that golang support works
  • Install a user extension and then start a new repo and check that they are installed.

fixes #5104

@roboquat roboquat requested a review from csweichel August 8, 2021 06:08
@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #5108 (ed571be) into main (4d47edc) will increase coverage by 37.43%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5108       +/-   ##
=========================================
+ Coverage      0   37.43%   +37.43%     
=========================================
  Files         0       16       +16     
  Lines         0     4084     +4084     
=========================================
+ Hits          0     1529     +1529     
- Misses        0     2430     +2430     
- Partials      0      125      +125     
Flag Coverage Δ
components-supervisor-app 37.43% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/supervisor/supervisor.go 6.49% <50.00%> (ø)
components/supervisor/pkg/ports/tunnel.go 63.63% <0.00%> (ø)
components/supervisor/pkg/supervisor/config.go 4.51% <0.00%> (ø)
components/supervisor/pkg/supervisor/tasks.go 55.22% <0.00%> (ø)
...mponents/supervisor/pkg/supervisor/notification.go 83.95% <0.00%> (ø)
components/supervisor/pkg/supervisor/git.go 0.00% <0.00%> (ø)
components/supervisor/pkg/dropwriter/dropwriter.go 73.46% <0.00%> (ø)
components/supervisor/pkg/ports/ports.go 59.33% <0.00%> (ø)
components/supervisor/pkg/ports/exposed-ports.go 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d47edc...ed571be. Read the comment docs.

@roboquat roboquat added size/L and removed size/XS labels Aug 8, 2021
@csweichel
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Aug 8, 2021

LGTM label has been added.

Git tree hash: 2660f13f626b993159a675abac04b41becde663b

@roboquat
Copy link
Contributor

roboquat commented Aug 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #5104

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit a31e09f into main Aug 8, 2021
@roboquat roboquat deleted the akosyakov/server-gitpod-resolved-5104 branch August 8, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[server] GITPOD_RESOLVED_EXTENSIONS is not valid json
3 participants