Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[content-service] Fix error check expression #5081

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 5, 2021

No description provided.

@roboquat roboquat requested a review from rl-gitpod August 5, 2021 23:52
@aledbf
Copy link
Member Author

aledbf commented Aug 5, 2021

/assign @csweichel

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #5081 (e52f16a) into main (90f3a7f) will increase coverage by 31.29%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5081       +/-   ##
=========================================
+ Coverage      0   31.29%   +31.29%     
=========================================
  Files         0       70       +70     
  Lines         0    14770    +14770     
=========================================
+ Hits          0     4623     +4623     
- Misses        0     9731     +9731     
- Partials      0      416      +416     
Flag Coverage Δ
components-content-service-app 14.47% <0.00%> (?)
components-content-service-lib 14.47% <0.00%> (?)
components-image-builder-app 34.44% <ø> (?)
components-image-builder-mk3-app 6.72% <ø> (?)
components-supervisor-app 36.47% <ø> (?)
components-ws-daemon-app 23.02% <ø> (?)
components-ws-manager-app 36.32% <ø> (?)
components-ws-proxy-app 67.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/content-service/pkg/service/workspace-service.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/probe.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/imagespec.go 0.00% <0.00%> (ø)
components/image-builder/pkg/resolve/resolve.go 35.76% <0.00%> (ø)
components/ws-daemon/pkg/internal/session/store.go 19.38% <0.00%> (ø)
components/ws-proxy/pkg/proxy/config.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/manager.go 24.89% <0.00%> (ø)
components/supervisor/pkg/ports/tunnel.go 63.63% <0.00%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f3a7f...e52f16a. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 6, 2021
@roboquat
Copy link
Contributor

roboquat commented Aug 6, 2021

LGTM label has been added.

Git tree hash: 211fc82c7a7fcf9a12bd709a34225ac50ec1022a

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Aug 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit eab51f4 into main Aug 6, 2021
@roboquat roboquat deleted the aledbf/checkerr branch August 6, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants