-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Projects] Fixing branch details #5048
Conversation
AlexTugarev
commented
Aug 4, 2021
- fixes Only prebuilds for the default branch are surfaced on the projects list #5002
- removes arbitrary limitation of branches from server. instead applying a limit of 10 after filtering on frontend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AlexTugarev! Looks good to merged once mock data are removed. 🍊
Not sure if mock data does override the prebuild information on the project card but this seems to work as expected.
What do you think of
The project cards could also use some facelift as seen in the sepcs in #5002 (comment) but sounds ok to leave this out of the scope of these changes. 🧀
BEFORE | AFTER |
---|---|
LGTM label has been added. Git tree hash: 549627828f58702479f0dc3c0002097d65b69985
|
7c6ccaa
to
1a4b137
Compare
LGTM label has been added. Git tree hash: 6feaa549dac4136f33a8a4d0625570438ac7310d
|
/hold cancel |
1a4b137
to
06b0bb9
Compare
New changes are detected. LGTM label has been removed. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexTugarev, gtsiolis Associated issue: #5002 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |