Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpctl] Improve image builds #5015

Merged
merged 1 commit into from
Jul 29, 2021
Merged

[gpctl] Improve image builds #5015

merged 1 commit into from
Jul 29, 2021

Conversation

csweichel
Copy link
Contributor

Choose a free port when doing the port-forwarding to image builder. This allows the parallel build of images.
Also add "AuthFor: all" to allow building from any registry the image builder has access to.

/approve no-issue

@roboquat roboquat requested a review from rl-gitpod July 29, 2021 15:52
@csweichel
Copy link
Contributor Author

/approve no-issue

@csweichel csweichel requested review from JanKoehnlein and removed request for rl-gitpod July 29, 2021 15:53
@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7beafb2810710920bde9943a866f7d3457e0f5a1

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, JanKoehnlein

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 75d49f7 into main Jul 29, 2021
@roboquat roboquat deleted the cw/gpctl-imagebuilds-improv branch July 29, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants