-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] Fix alignment of pending changes widget in workspaces list #4986
Conversation
3db3b46
to
bae147f
Compare
Codecov Report
@@ Coverage Diff @@
## main #4986 +/- ##
===========================================
+ Coverage 23.02% 36.54% +13.51%
===========================================
Files 11 13 +2
Lines 1915 3719 +1804
===========================================
+ Hits 441 1359 +918
- Misses 1415 2244 +829
- Partials 59 116 +57
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
bae147f
to
4e0460b
Compare
/hold please don't merge all those reverts |
Agreed. I'm blindly reverting anything "suspicious" until workspace backups work again 😇 (because I need a successful backup in order to test a tiny "pending changes" UI fix 🙄) EDIT: Well, reverting didn't help. I'll undo the reverts and wait for backups to be properly fixed. 😊 |
4e0460b
to
0dc8bf4
Compare
0dc8bf4
to
3a95305
Compare
Looking at this now! 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM label has been added. Git tree hash: 8d7eef69c688d5d1399b765ce377663eb10cc175
|
/unhold |
@jankeromnes could you also approve this, see relevant comment. 🙏 |
Thanks a lot for the review @gtsiolis! 🙌
Er, what 😂 /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gtsiolis, jankeromnes Associated issue: #4670 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #4670
Now looks like this: