-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't mark prebuilds with failing tasks unavailable #4975
Conversation
/auto-cc |
Codecov Report
@@ Coverage Diff @@
## main #4975 +/- ##
===========================================
+ Coverage 23.02% 36.34% +13.32%
===========================================
Files 11 13 +2
Lines 1915 3747 +1832
===========================================
+ Hits 441 1362 +921
- Misses 1415 2270 +855
- Partials 59 115 +56
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
components/ws-manager/pkg/manager/testdata/status_headlessTaskFailed_STOPPING00.json
Show resolved
Hide resolved
f100a7c
to
5a2cd98
Compare
@geropl debug leftover is removed. Please have another look |
/werft run 👍 started the job as gitpod-build-csweichel-don-t-abort-prebuild-4964.4 |
5a2cd98
to
ed9bcd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, tested and worked 👍
LGTM label has been added. Git tree hash: 633a975dcfd6b697616f5278363f392b12b1f86c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel, geropl Associated issue: #4964 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR correctly marks prebuilds with a failed headless task as available, and updates ws-manager to not spuriously add the
failed
condition if the headless task fails.fixes #4964
How to test