Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old headless log infrastructure #4915

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Jul 22, 2021

This PR removes the last leftovers of the old headless log infrastructure.

fixes #4911

Noteworthy:

  • there's a protocol change on ws-manager's SubscriptionResponse which removes the oneof. To my understanding that doesn't affect what's on the wire, i.e. the protocol should remain backwards compatible. That's because neither numbers nor types of the fields change.

@roboquat roboquat requested a review from rl-gitpod July 22, 2021 18:11
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #4915 (77368a1) into main (3bb79b0) will increase coverage by 1.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4915      +/-   ##
==========================================
+ Coverage   38.15%   39.22%   +1.07%     
==========================================
  Files          24       25       +1     
  Lines        6013     6488     +475     
==========================================
+ Hits         2294     2545     +251     
- Misses       3539     3752     +213     
- Partials      180      191      +11     
Flag Coverage Δ
components-ee-ws-scheduler-app 62.68% <ø> (?)
components-image-builder-app ?
components-image-builder-mk3-app 6.53% <ø> (ø)
components-local-app-app-darwin ?
components-local-app-app-linux ?
components-local-app-app-windows ?
components-ws-manager-app 36.54% <0.00%> (+0.01%) ⬆️
components-ws-proxy-app ?
dev-loadgen-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/manager.go 24.89% <0.00%> (+0.05%) ⬆️
components/image-builder/pkg/resolve/resolve.go 34.78% <0.00%> (-0.99%) ⬇️
components/ws-proxy/pkg/proxy/pass.go
components/ws-proxy/pkg/proxy/infoprovider.go
components/ws-proxy/pkg/proxy/cookies.go
components/ws-proxy/pkg/proxy/workspacerouter.go
components/ws-proxy/pkg/proxy/routes.go
components/ws-proxy/pkg/proxy/config.go
components/ws-proxy/pkg/proxy/auth.go
components/ws-proxy/pkg/proxy/proxy.go
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb79b0...77368a1. Read the comment docs.

@csweichel csweichel force-pushed the csweichel/remove-old-headless-log-4911 branch from f5c3b02 to 9d11392 Compare July 22, 2021 18:14
@csweichel csweichel requested review from aledbf, akosyakov and geropl and removed request for rl-gitpod July 22, 2021 18:15
@csweichel csweichel force-pushed the csweichel/remove-old-headless-log-4911 branch from 9d11392 to 3b89476 Compare July 22, 2021 18:19
@csweichel csweichel force-pushed the csweichel/remove-old-headless-log-4911 branch from 3b89476 to 77368a1 Compare July 22, 2021 18:36
@aledbf
Copy link
Member

aledbf commented Jul 23, 2021

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: a9e98419e7932402892aaa5ac9a9d0e62311eabb

@csweichel
Copy link
Contributor Author

/assign @geropl

@geropl
Copy link
Member

geropl commented Jul 26, 2021

/werft run

👍 started the job as gitpod-build-csweichel-remove-old-headless-log-4911.8

@geropl
Copy link
Member

geropl commented Jul 26, 2021

Maybe unrelated, but I'm not able to start a prebuild workspace on https://csweichel-remove-old-headless-log-4911.staging.gitpod-dev.com/#prebuild/https://github.com/gitpod-io/gitpod/tree/gpl/test-prebuild

The image build pod does not terminate. Logs read:

{"command":"{\nsudo -E /app/bob build\n}; exit","level":"info","message":"task terminal has been closed","pid":29,"serviceContext":{"service":"supervisor","version":""},"severity":"INFO","terminal":"4c016f29-13ce-49e0-89b2-f6982037b25f","time":"2021-07-26T08:16:36Z"}
{"component":"workspace","level":"info","message":"","serviceContext":{"service":"supervisor","version":""},"severity":"INFO","taskLogMsg":{"type":"workspaceTaskOutput","data":"🚛 uploading prebuilt workspace"},"time":"2021-07-26T08:16:36Z"}
{"component":"workspace","level":"info","message":"","serviceContext":{"service":"supervisor","version":""},"severity":"INFO","taskLogMsg":{"type":"workspaceTaskDone","data":""},"time":"2021-07-26T08:16:36Z"}
{"alias":"4c016f29-13ce-49e0-89b2-f6982037b25f","level":"info","message":"terminal client left","serviceContext":{"service":"supervisor","version":""},"severity":"INFO","time":"2021-07-26T08:16:36Z"}
{"component":"workspace","level":"info","message":"","pid":29,"serviceContext":{"service":"supervisor","version":""},"severity":"INFO","taskLogMsg":{"type":"workspaceTaskOutput","data":""},"time":"2021-07-26T08:16:36Z"}
{"level":"info","message":"received SIGTERM (or shutdown) - tearing down","serviceContext":{"service":"supervisor","version":""},"severity":"INFO","time":"2021-07-26T08:16:36Z"}
{"level":"debug","message":"tasksManager shutdown","serviceContext":{"service":"supervisor","version":""},"severity":"DEBUG","time":"2021-07-26T08:16:36Z"}
{"level":"info","message":"shutting down API endpoint","serviceContext":{"service":"supervisor","version":""},"severity":"INFO","time":"2021-07-26T08:16:36Z"}
{"@type":"type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent","error":"context canceled","level":"error","message":"cannot provide Docker activation socket","serviceContext":{"service":"supervisor","version":""},"severity":"ERROR","time":"2021-07-26T08:16:36Z"}
{"level":"debug","message":"startAPIEndpoint shutdown","serviceContext":{"service":"supervisor","version":""},"severity":"DEBUG","time":"2021-07-26T08:16:36Z"}
{"@type":"type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent","error":"wait: no child processes","level":"warning","message":"cannot terminate child process","pid":40,"serviceContext":{"service":"supervisor","version":""},"severity":"WARNING","time":"2021-07-26T08:16:36Z"}
{"exitCode":0,"level":"debug","message":"supervisor exit","serviceContext":{"service":"supervisor","version":""},"severity":"DEBUG","time":"2021-07-26T08:16:36Z"}

@geropl
Copy link
Member

geropl commented Jul 26, 2021

Ok, now it started. 🤷 The image build hang for 14-20 mins, but somehow finished, and the prebuild ran flawlessly afterwards.

The second run worked flawlessly.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works. The hickups are related to image-builder mk3, not this PR.

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel, geropl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geropl
Copy link
Member

geropl commented Jul 26, 2021

@csweichel Makes sense to override codecov/patch I assume...?

@roboquat roboquat merged commit 140c897 into main Jul 28, 2021
@roboquat roboquat deleted the csweichel/remove-old-headless-log-4911 branch July 28, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old headless log remnants
4 participants