-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old headless log infrastructure #4915
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4915 +/- ##
==========================================
+ Coverage 38.15% 39.22% +1.07%
==========================================
Files 24 25 +1
Lines 6013 6488 +475
==========================================
+ Hits 2294 2545 +251
- Misses 3539 3752 +213
- Partials 180 191 +11
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
f5c3b02
to
9d11392
Compare
9d11392
to
3b89476
Compare
3b89476
to
77368a1
Compare
/lgtm |
LGTM label has been added. Git tree hash: a9e98419e7932402892aaa5ac9a9d0e62311eabb
|
/assign @geropl |
/werft run 👍 started the job as gitpod-build-csweichel-remove-old-headless-log-4911.8 |
Maybe unrelated, but I'm not able to start a prebuild workspace on https://csweichel-remove-old-headless-log-4911.staging.gitpod-dev.com/#prebuild/https://github.com/gitpod-io/gitpod/tree/gpl/test-prebuild The image build pod does not terminate. Logs read:
|
Ok, now it started. 🤷 The image build hang for 14-20 mins, but somehow finished, and the prebuild ran flawlessly afterwards. The second run worked flawlessly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works. The hickups are related to image-builder mk3, not this PR.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, csweichel, geropl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@csweichel Makes sense to override codecov/patch I assume...? |
This PR removes the last leftovers of the old headless log infrastructure.
fixes #4911
Noteworthy:
SubscriptionResponse
which removes theoneof
. To my understanding that doesn't affect what's on the wire, i.e. the protocol should remain backwards compatible. That's because neither numbers nor types of the fields change.