Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Don't count ToS rejection to login metric #4888

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

csweichel
Copy link
Contributor

hopefully

fixes #4296

@roboquat roboquat requested a review from geropl July 21, 2021 08:23
@csweichel csweichel requested review from AlexTugarev and removed request for geropl July 21, 2021 08:23
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 79a9e670c998cdfc475e6a31ab71cdf892ab838f

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev, csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit c94f7ba into main Jul 21, 2021
@roboquat roboquat deleted the csweichel/missing-terms-of-service-4296 branch July 21, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing terms of service approval on Gitlab causes login error and related SLO impact
3 participants