Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Add invite members button on projects page #4868

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

gtsiolis
Copy link
Contributor

This will add a button to invite members on the projects page that links to the Members page.

BEFORE AFTER
Screenshot 2021-07-19 at 3 23 52 PM Screenshot 2021-07-19 at 3 23 48 PM

@gtsiolis gtsiolis force-pushed the gt/add-invite-members-button branch from 7d9bea9 to 196dcda Compare July 19, 2021 12:31
@gtsiolis gtsiolis changed the title [dashboard] Add invite member button on projects page [dashboard] Add invite members button on projects page Jul 19, 2021
@gtsiolis
Copy link
Contributor Author

/meow

@roboquat
Copy link
Contributor

@gtsiolis: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gtsiolis gtsiolis removed the request for review from corneliusludmann July 19, 2021 13:32
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: dda9cebe79a93714931a360ee4ba438b5cd00116

@svenefftinge
Copy link
Member

/assign @geropl

@svenefftinge
Copy link
Member

svenefftinge commented Jul 20, 2021

/werft run

👍 started the job as gitpod-build-gt-add-invite-members-button.2

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jul 27, 2021

/werft run

👍 started the job as gitpod-build-gt-add-invite-members-button.3

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Aug 5, 2021

@jankeromnes could you take a look at this one-line change and approve if this looks good? Pinging you since you were involved in adding the Members section. Feel free to forward this to someone else on the crew if needed. 🏓

@gtsiolis gtsiolis requested a review from jankeromnes August 5, 2021 16:34
@jankeromnes
Copy link
Contributor

jankeromnes commented Aug 5, 2021

Sure! Happy to. 🚀

Side-note: You can also manually manage the labels that @roboquat adds (i.e. approved and lgtm) 😁

/lgtm

/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Aug 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes, svenefftinge

Associated issue requirement bypassed by: jankeromnes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants