[Analytics] Fixed wrong name in signup tracking #4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhero
requested review from
a team and
geropl
and removed request for
a team
geropl
reviewed
Jul 15, 2021
| @@ -517,7 +517,7 @@ export class UserController { | |||
| properties: { | |||
| "auth_provider": user.identities[0].authProviderId, | |||
| "email": User.getPrimaryEmail(user), | |||
| "name": User.getName(user), | |||
| "name": user.identities[0].authName, | |||
There was a problem hiding this comment.
I see how that fixes the particular issue. But I wonder how we're sure that identities[0] is what we want? But outside of scope I guess.
geropl
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that fullName instead of name is passed to name attribute in analytics signup tracking call.
/werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe