Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Fix timeouts for SAAS #4819

Merged
merged 1 commit into from
Jul 15, 2021
Merged

[server] Fix timeouts for SAAS #4819

merged 1 commit into from
Jul 15, 2021

Conversation

geropl
Copy link
Member

@geropl geropl commented Jul 14, 2021

Fixes #4760.

After merging gitpod-com back into gitpod-io we forgot to cleanup workspace timeouts across different plans as that code conflicted with the Self-Hosted implementation

  • /werft with-payment

After merging gitpod-com back into gitpod-io we forgot to cleanup workspace timeouts across different plans as that code conflicted with the Self-Hosted implementation
@geropl geropl requested review from a team and corneliusludmann and removed request for a team July 14, 2021 14:53
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geropl
Copy link
Member Author

geropl commented Jul 15, 2021

/werft run

👍 started the job as gitpod-build-gpl-fix-timeouts.2

@geropl
Copy link
Member Author

geropl commented Jul 15, 2021

Tested `with-payment: works ✔️
image

@geropl geropl merged commit c93a9f0 into main Jul 15, 2021
@geropl geropl deleted the gpl/fix-timeouts branch July 15, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[server] Fix subscription-based default timeouts
2 participants