Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Improve ws-daemon logs #4789

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

csweichel
Copy link
Contributor

This PR improves the logging of ws-daemon and nsinsider so that we can understand the impact of the critical logs in prod.

Helps debugging #4784.

@csweichel csweichel requested review from svenefftinge, a team and aledbf and removed request for a team July 13, 2021 08:38
@csweichel
Copy link
Contributor Author

csweichel commented Jul 13, 2021

/werft run no-preview

👍 started the job as gitpod-build-csweichel-ws-daemon-fails-mounting-4784.1

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #4789 (700b8f8) into main (f654391) will increase coverage by 22.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4789       +/-   ##
=========================================
+ Coverage      0   22.67%   +22.67%     
=========================================
  Files         0       13       +13     
  Lines         0     2055     +2055     
=========================================
+ Hits          0      466      +466     
- Misses        0     1527     +1527     
- Partials      0       62       +62     
Flag Coverage Δ
components-ws-daemon-app 22.67% <ø> (?)
components-ws-daemon-nsinsider-app ∅ <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/resources/controller.go 34.05% <0.00%> (ø)
components/ws-daemon/pkg/resources/dispatch.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/tar.go 45.63% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/archive.go 57.47% <0.00%> (ø)
components/ws-daemon/pkg/quota/mounts.go 53.19% <0.00%> (ø)
components/ws-daemon/pkg/resources/limiter.go 77.77% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
components/ws-daemon/pkg/internal/session/store.go 19.38% <0.00%> (ø)
components/ws-daemon/pkg/content/config.go 62.50% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f654391...700b8f8. Read the comment docs.

@csweichel csweichel merged commit b81f00b into main Jul 13, 2021
@csweichel csweichel deleted the csweichel/ws-daemon-fails-mounting-4784 branch July 13, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants