Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[werft] Disable dynamic ws-manager cert generation #4725

Merged
merged 2 commits into from
Jul 7, 2021
Merged

[werft] Disable dynamic ws-manager cert generation #4725

merged 2 commits into from
Jul 7, 2021

Conversation

geropl
Copy link
Member

@geropl geropl commented Jul 7, 2021 •
edited
Loading

This PR does two things:

  • reorders deploy stepts so we don't have to use an explicit promise in the build job
  • ties down all dependencies for the build job

The former seems* to have fixed our issue (*because we're not sure what caused it in the first place). The later is added because

  1. it's a good thing to have anyway
  2. we have a handle on the dependencies and can easily alter them in case we find an offending one
  • /werft with-clean-slate-deployment

@geropl geropl force-pushed the gpl/fix-core-dev-certs branch 12 times, most recently from 7ab053f to 8423daf Compare July 7, 2021 12:33
@geropl geropl marked this pull request as ready for review July 7, 2021 12:56
@geropl geropl requested a review from a team as a code owner July 7, 2021 12:56
@geropl geropl requested review from fntlnz and princerachit and removed request for a team July 7, 2021 12:56
@geropl geropl force-pushed the gpl/fix-core-dev-certs branch from 8423daf to f432ec3 Compare July 7, 2021 13:03
@geropl geropl force-pushed the gpl/fix-core-dev-certs branch from f432ec3 to 208df38 Compare July 7, 2021 13:06
princerachit
princerachit reviewed Jul 7, 2021
View reviewed changes
.werft/build.ts

werft.done('prep');
} catch (err) {
werft.fail('prep', err);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: What if the certificate phase errors out?

princerachit
princerachit approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@princerachit princerachit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge after build

@geropl geropl merged commit 0adf586 into main Jul 7, 2021
@geropl geropl deleted the gpl/fix-core-dev-certs branch July 7, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@princerachit princerachit princerachit approved these changes

@fntlnz fntlnz Awaiting requested review from fntlnz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geropl @princerachit