Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Update more GitLab integration settings URLs #4705

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Jul 5, 2021

This will update some more GitLab integretion settings URLs following the updates in #4462. 🦊

@gtsiolis gtsiolis requested a review from a team as a code owner July 5, 2021 12:54
@gtsiolis gtsiolis requested a review from a team July 5, 2021 12:54
@gtsiolis gtsiolis force-pushed the gt/update-more-integration-settings-urls branch from cef1887 to 8fdbc41 Compare July 5, 2021 12:58
@gtsiolis gtsiolis changed the title Update more GitLab integration settings URLs [dashboard] Update more GitLab integration settings URLs Jul 5, 2021
@gtsiolis gtsiolis force-pushed the gt/update-more-integration-settings-urls branch from 8fdbc41 to b783ff4 Compare July 5, 2021 12:59
@gtsiolis gtsiolis changed the title [dashboard] Update more GitLab integration settings URLs [server] Update more GitLab integration settings URLs Jul 5, 2021
@@ -9,6 +9,6 @@ export function oauthUrls(host: string) {
return {
authorizationUrl: `https://${host}/oauth/authorize`,
tokenUrl: `https://${host}/oauth/token`,
settingsUrl: `https://${host}/profile/applications`,
settingsUrl: `https://${host}/-/profile/applications`,
Copy link
Contributor Author

@gtsiolis gtsiolis Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably the most important change here. 😇

@corneliusludmann
Copy link
Contributor

FYI: There are also 2 occurrences in our gitpod-com repo. However, I don't think they are crucial.

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jul 5, 2021

Thanks for taking a look @corneliusludmann! Merging this and adding a PR for updating those other 2 occurrences for consistency.

@gtsiolis gtsiolis merged commit 9628909 into main Jul 5, 2021
@gtsiolis gtsiolis deleted the gt/update-more-integration-settings-urls branch July 5, 2021 13:14
MatthewFagan pushed a commit to trilogy-group/gitpod that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants