-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] Update more GitLab integration settings URLs #4705
Conversation
cef1887
to
8fdbc41
Compare
8fdbc41
to
b783ff4
Compare
@@ -9,6 +9,6 @@ export function oauthUrls(host: string) { | |||
return { | |||
authorizationUrl: `https://${host}/oauth/authorize`, | |||
tokenUrl: `https://${host}/oauth/token`, | |||
settingsUrl: `https://${host}/profile/applications`, | |||
settingsUrl: `https://${host}/-/profile/applications`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably the most important change here. 😇
FYI: There are also 2 occurrences in our gitpod-com repo. However, I don't think they are crucial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks for taking a look @corneliusludmann! Merging this and adding a PR for updating those other 2 occurrences for consistency. |
This will update some more GitLab integretion settings URLs following the updates in #4462. 🦊