Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Remove Containerd4214 workaround #4683

Merged
merged 1 commit into from
Jul 20, 2021
Merged

[ws-daemon] Remove Containerd4214 workaround #4683

merged 1 commit into from
Jul 20, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 2, 2021

/werft with-retag

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #4683 (37aefaf) into main (035fa4e) will increase coverage by 22.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4683       +/-   ##
=========================================
+ Coverage      0   22.29%   +22.29%     
=========================================
  Files         0       13       +13     
  Lines         0     2090     +2090     
=========================================
+ Hits          0      466      +466     
- Misses        0     1562     +1562     
- Partials      0       62       +62     
Flag Coverage Δ
components-ws-daemon-app 22.29% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/quota/size.go 87.30% <0.00%> (ø)
components/ws-daemon/pkg/content/archive.go 57.47% <0.00%> (ø)
components/ws-daemon/pkg/resources/dispatch.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/quota/mounts.go 53.19% <0.00%> (ø)
components/ws-daemon/pkg/quota/sandbox_linux.go 0.00% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
components/ws-daemon/pkg/resources/limiter.go 77.77% <0.00%> (ø)
components/ws-daemon/pkg/internal/session/store.go 19.38% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/config.go 62.50% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035fa4e...37aefaf. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Jul 2, 2021

/werft run

👍 started the job as gitpod-build-aledbf-retag.6

@aledbf aledbf force-pushed the aledbf/retag branch 5 times, most recently from 8662352 to 440c6ac Compare July 12, 2021 10:37
@aledbf
Copy link
Member Author

aledbf commented Jul 12, 2021

/werft run

👍 started the job as gitpod-build-aledbf-retag.17

@aledbf
Copy link
Member Author

aledbf commented Jul 16, 2021

/werft run

👍 started the job as gitpod-build-aledbf-retag.25

@aledbf aledbf marked this pull request as ready for review July 20, 2021 17:59
@csweichel
Copy link
Contributor

I've checked the logs and as expected we haven't seen this happening lately due to the upgrade to a more recent containerd version.

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9e218b047977b5d895706e4d71f96c28d8e5675a

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants