Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] wait for extension host to activate cli server #4633

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 28, 2021

  • /werft with-clean-slate-deployment

What it does

This PR alignes with the behaviour which had before in Theia, namely, Code CLI waits till there is at least one client before sending a command without any timeouts.

Change in Gitpod Code: gitpod-io/openvscode-server@6b591c2

How to test

@akosyakov akosyakov changed the title [code] fix #4036: wait for extension host to activate cli server [code] wait for extension host to activate cli server Jun 28, 2021
@akosyakov akosyakov force-pushed the akosyakov/gp-open-preview-should-4036 branch from 6e4d146 to d936ba4 Compare June 28, 2021 11:25
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanKoehnlein JanKoehnlein marked this pull request as ready for review June 28, 2021 12:29
@JanKoehnlein JanKoehnlein merged commit deca404 into main Jun 28, 2021
@JanKoehnlein JanKoehnlein deleted the akosyakov/gp-open-preview-should-4036 branch June 28, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gp open/preview should await till UI is available
2 participants