Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] Revert #4338 and fix /dev/net/tun permissions #4596

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 23, 2021

Screenshot from 2021-06-23 17-26-28

@fntlnz thank you for finding the issue :)

@aledbf aledbf requested a review from csweichel June 23, 2021 21:03
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #4596 (57fb2c3) into main (8552d9e) will increase coverage by 36.22%.
The diff coverage is n/a.

❗ Current head 57fb2c3 differs from pull request most recent head aa746cd. Consider uploading reports for the commit aa746cd to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4596       +/-   ##
=========================================
+ Coverage      0   36.22%   +36.22%     
=========================================
  Files         0       14       +14     
  Lines         0     3865     +3865     
=========================================
+ Hits          0     1400     +1400     
- Misses        0     2348     +2348     
- Partials      0      117      +117     
Flag Coverage Δ
components-ws-manager-app 36.22% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/create.go 78.91% <ø> (ø)
components/ws-manager/pkg/manager/headless.go 44.00% <0.00%> (ø)
...s/ws-manager/pkg/manager/internal/grpcpool/pool.go 74.46% <0.00%> (ø)
components/ws-manager/pkg/manager/probe.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/status.go 72.14% <0.00%> (ø)
components/ws-manager/pkg/manager/metrics.go 11.26% <0.00%> (ø)
...omponents/ws-manager/pkg/manager/pod_controller.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/annotations.go 66.66% <0.00%> (ø)
components/ws-manager/pkg/manager/monitor.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8552d9e...aa746cd. Read the comment docs.

@aledbf aledbf force-pushed the aledbf/reverttun branch from 57fb2c3 to aa746cd Compare June 23, 2021 21:20
@aledbf aledbf merged commit b6eaadb into main Jun 23, 2021
@aledbf aledbf deleted the aledbf/reverttun branch June 23, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants