Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workspaceUrlPrefixRegex #4536

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Fix workspaceUrlPrefixRegex #4536

merged 1 commit into from
Jun 17, 2021

Conversation

corneliusludmann
Copy link
Contributor

Fixes the “Open Workspace” button on the stopped page.

Works for deployments like:

but still fails if the branch prefix looks like a workspace ID, e.g. this would still fail because abc-brunch-4224123 is a valid workspace ID:

AlexTugarev
AlexTugarev approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open Workspace link work again! 🎉

🎉 More tests! 🎉

@corneliusludmann corneliusludmann merged commit a22da4e into main Jun 17, 2021
@corneliusludmann corneliusludmann deleted the clu/fix-open-open branch June 17, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corneliusludmann @AlexTugarev