[content-service] Retry git clone #4506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4506 +/- ##
==========================================
+ Coverage 30.51% 34.26% +3.74%
==========================================
Files 29 60 +31
Lines 4683 12710 +8027
==========================================
+ Hits 1429 4355 +2926
- Misses 3139 7957 +4818
- Partials 115 398 +283 Continue to review full report at Codecov.
|
|
/werft run 👎 not authorized |
|
/werft run 👍 started the job as gitpod-build-clu-ws-daemon-retry-4203.2 |
|
/werft run 👍 started the job as gitpod-build-clu-ws-daemon-retry-4203.3 |
JanKoehnlein
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces an exponential backoff retry of
git clone. It retries until a timeout of 5 minutes (we could also use another timeout duration if someone has another proposal).Fixes #4203
How to test
To be honest, I have no idea how to test this. A good start is to verify that it is still possible to start a workspace, though.