Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] logging to track reconnection cause #4498

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Conversation

akosyakov
Copy link
Member

What it does

  • It adds logging to determine a cause of web socket closing.
  • It also changes the default websocket in VS Code Web:
    • by default VS Code will try to reconnect the websocket only if it was not closed cleanly (1000 code)
    • in our case it is better to reconnect always when workspace phase is running regardless of websocket close code
  • fix code frontend fails to load sometimes #4448: makes sure that grpc-web is loaded before the local app

Changes in Gitpod Code: microsoft/vscode@e2eb3ee...a6ceaaf

How to test

  • Start a workspace.
  • Run WebSocket.disconnectWorkspace and check web sockets are reconnected within a minute.
  • Throttle network on system level, like with Edge profile, and see that web sockets still get connected and reconnected.

@akosyakov akosyakov requested a review from JanKoehnlein June 14, 2021 07:13
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosyakov akosyakov merged commit b87595a into main Jun 14, 2021
@akosyakov akosyakov deleted the ak/vscode_web_socket branch June 14, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code frontend fails to load sometimes
2 participants