Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable debugging of a single VS Code extension #4446

Merged
merged 1 commit into from
Jun 10, 2021
Merged

enable debugging of a single VS Code extension #4446

merged 1 commit into from
Jun 10, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 9, 2021 •
edited
Loading

What it does

Changes in Code: gitpod-io/openvscode-server@e2eb3ee

Important: We should wait merging till #4444 is merged

How to test

JanKoehnlein
JanKoehnlein approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Breakpoint was hit as well

@corneliusludmann
Copy link
Contributor

@akosyakov Do you need a review from me as well or is Jan's review sufficient?

@akosyakov
Copy link
Member Author

@akosyakov Do you need a review from me as well or is Jan's review sufficient?

sufficient!

@corneliusludmann corneliusludmann removed their request for review June 9, 2021 07:24
@akosyakov akosyakov force-pushed the ak/debug_vscode_ext branch from afdb3b3 to b888a84 Compare June 10, 2021 01:52
@akosyakov akosyakov merged commit 3824911 into main Jun 10, 2021
@akosyakov akosyakov deleted the ak/debug_vscode_ext branch June 10, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKoehnlein JanKoehnlein JanKoehnlein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to debug VSCode extension - VSCode extension not loaded during the debug process
3 participants
@akosyakov @corneliusludmann @JanKoehnlein