Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Fix workspaces list dark text colors #4410

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

corneliusludmann
Copy link
Contributor

@corneliusludmann corneliusludmann commented Jun 7, 2021

Before This PR
image image

Fixes #4194

@corneliusludmann corneliusludmann force-pushed the corneliusludmann/update-workspaces-4194 branch 2 times, most recently from b1c0570 to 2f0d224 Compare June 7, 2021 18:22
@corneliusludmann corneliusludmann marked this pull request as ready for review June 7, 2021 18:46
@corneliusludmann corneliusludmann requested a review from gtsiolis June 7, 2021 18:46
@corneliusludmann corneliusludmann force-pushed the corneliusludmann/update-workspaces-4194 branch from 2f0d224 to aa95cd7 Compare June 7, 2021 18:48
@gtsiolis
Copy link
Contributor

gtsiolis commented Jun 8, 2021

/werft run

👍 started the job as gitpod-build-corneliusludmann-update-workspaces-4194.4

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much better! Thanks for fixing this @corneliusludmann! 🌙

@@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file.

## June 2021

- Fix text color in workspaces list for dark theme ([#4410](https://github.com/gitpod-io/gitpod/pull/4410))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks for adding a changelog for this! 🎉

@corneliusludmann corneliusludmann merged commit c645cb9 into main Jun 8, 2021
@corneliusludmann corneliusludmann deleted the corneliusludmann/update-workspaces-4194 branch June 8, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update workspaces list colors in dark theme
2 participants