Enable having integration tests run as a PR pre-merge check #4362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run 👍 started the job as gitpod-build-mads-pr-check-integration-tests.12 |
|
/werft run 👍 started the job as gitpod-build-mads-pr-check-integration-tests.13 |
csweichel
approved these changes
Jun 4, 2021
This will currently fail as we don't have the right version of Werft yet
This reverts commit cd2c511.
mads-hartmann
force-pushed
the
mads/pr-check-integration-tests
branch
from
9538ea1 to
06a276e
Compare
|
/werft run 👍 started the job as gitpod-build-mads-pr-check-integration-tests.22 |
corneliusludmann
pushed a commit
that referenced
this pull request
Jun 15, 2021
This is a step towards running integration tests on all PRs and have it be a requirement for merging. Specifically this commit introduces the following changes: - Trigger the integration test job without using the --follow-with-prefix - this allows the build job to succeed independently of the the result of the integration tests. - The job is triggered in such a way that a ci/werft/run-integration-tests commit check will be created (this was made possible by making changes to Werft, thanks @csweichel) After this is merged we can - Configure Github to have ci/werft/run-integration-tests be a required check. That means people can't merge a PR unless the check succeed. This should only be done once we run integration tests by default.
MatthewFagan
pushed a commit
to trilogy-group/gitpod
that referenced
this pull request
Nov 24, 2021
…o#4362) This is a step towards running integration tests on all PRs and have it be a requirement for merging. Specifically this commit introduces the following changes: - Trigger the integration test job without using the --follow-with-prefix - this allows the build job to succeed independently of the the result of the integration tests. - The job is triggered in such a way that a ci/werft/run-integration-tests commit check will be created (this was made possible by making changes to Werft, thanks @csweichel) After this is merged we can - Configure Github to have ci/werft/run-integration-tests be a required check. That means people can't merge a PR unless the check succeed. This should only be done once we run integration tests by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a step towards running integration tests on all PRs and have it be a requirement for merging.
Specifically this PR introduces the following changes:
--follow-with-prefix- this allows the build job to succeed independently of the the result of the integration tests.ci/werft/run-integration-testscommit check will be created (this was made possible by making changes to Werft, thanks @csweichel)After this is merged we can
ci/werft/run-integration-testsbe a required check. That means people can't merge a PR unless the check succeed. This should only be done once we run integration tests by default.