[dashboard] Support multiple "Recent" projects with the same title #4312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTugarev
reviewed
May 27, 2021
| @@ -35,7 +35,7 @@ export function StartWorkspaceModal(p: StartWorkspaceModalProps) { | |||
| useEffect(() => setSelection(computeSelection()), [p.recent, p.selected]); | |||
|
|
|||
| const list = (selection === 'Recent' ? p.recent : p.examples).map(e => | |||
| <a key={e.title} href={e.startUrl} className="rounded-xl group hover:bg-gray-100 dark:hover:bg-gray-800 flex p-4 my-1"> | |||
| <a key={e.startUrl} href={e.startUrl} className="rounded-xl group hover:bg-gray-100 dark:hover:bg-gray-800 flex p-4 my-1"> | |||
There was a problem hiding this comment.
I think there is no guarantee for startUrl to be unique.
In such cases it's easy to add the index of element provided by map, e.g.
map((e, index) => {
... key={`element-${index}-` + e.startUrl}
})
There was a problem hiding this comment.
Oh, actually looking at the effect and L.37, it'd make sense to include selection into the key as well. Sorry for missing that, @jankeromnes.
BTW, could you please make https://gitlab.com/jankeromnes/gitpod-staging-prebuilds public to make it easier to test.
jankeromnes
force-pushed
the
jx/support-multiple-titles
branch
from
f6f2e2c to
e0367b9
Compare
jankeromnes
force-pushed
the
jx/support-multiple-titles
branch
from
e0367b9 to
fda71be
Compare
AlexTugarev
approved these changes
May 27, 2021
There was a problem hiding this comment.
It works as advertised! Thanks @jankeromnes
Just a note on #4312 (comment), I've no idea how to reproduce it actually. This is good so far 👍🏻
|
Thanks for fixing this @jankeromnes! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this:
Explanation
I believe using the same
keyon multiple elements in a list breaks React. This PR attempts to make the key unique.How to test
Expected: