Allow setting customTimeoutAnnotation for headless workspace pods #4239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
force-pushed
the
jx/headless-custom-timeouts
branch
2 times, most recently
from
84eec97 to
695a8d6
Compare
This comment has been minimized.
This comment has been minimized.
jankeromnes
force-pushed
the
jx/headless-custom-timeouts
branch
from
695a8d6 to
2640e4c
Compare
jankeromnes
force-pushed
the
jx/headless-custom-timeouts
branch
4 times, most recently
from
c52b49e to
df3a2c4
Compare
|
Seems to work as expected! 🙌 @csweichel please take a look when you have time |
…tead of the actual time spent
…ss workspace pods
jankeromnes
force-pushed
the
jx/headless-custom-timeouts
branch
from
df3a2c4 to
f6731ea
Compare
|
(I also snuck in a new test 😁 basically a copy of the timing-out prebuild, but with a custom timeout of 2h so that it doesn't time out.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes two things:
server: Don't setcustomTimeoutAnnotationwhen starting headless pods (currently ignored by ws-manager)ws-manager: HonorcustomTimeoutAnnotationfor headless pods (when it is set)See also Slack discussion (internal)
And also (optionally):
ws-manager: When a workspace times out, log both how long it took and the expected timeout (new)How to test
gitpod/customTimeoutlabel (e.g.30mif you're on the Open Source / Free plan)#prebuild/manual prefix)gitpod/customTimeoutlabelgitpod/customTimeoutlabel on the prebuild pod (e.g.1m), the prebuild should honor it instead of the default headless timeout (which is60m)