[dashboard] Hide 'stopping' & unpinned workspaces from 'Active' #4170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run 👍 started the job as gitpod-build-jx-hide-stopping.2 |
|
/werft run 👍 started the job as gitpod-build-jx-hide-stopping.3 |
gtsiolis
approved these changes
May 12, 2021
There was a problem hiding this comment.
Hey @jankeromnes! Thanks for giving this a spin.
Behavior for unpinned workspaces looks good. Should be fine to merge this and revert if the different behavior for deleting pinned workspaces causes any confusion.
.werft/values.dev.yaml
Outdated
| blockNewUsers: true | ||
| blockNewUsersPasslist: | ||
| - "gitpod.io" | ||
| blockNewUsers: false |
There was a problem hiding this comment.
reminder: To remove this before merging! 😇
There was a problem hiding this comment.
Indeed, split out into #4211
jankeromnes
force-pushed
the
jx/hide-stopping
branch
from
b1c6b75 to
3b7495f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential solution/workaround for #3879
How to test:
(It actually gets hidden and not removed, so you'll still see the "stopping" workspace in
Filter: All, but maybe that's okay for now.)(EDIT: Another potential difference is, if you delete a running pinned workspace, it will still continue to be displayed as "stopping" in
Filter: Activefor a while. A fix for that could be to immediately un-pin when you delete.)