[dashboard] redirect anonymous users to www. #3991
Conversation
in SaaS context we want to redirect not logged in users from the root URL with no additional context provided to the website URL. fixes #3898
| @@ -71,6 +71,12 @@ function App() { | |||
| } | |||
| }, [localStorage.theme]); | |||
|
|
|||
| if (window.location.pathname === '/' && window.location.hash === '' && !hasLoggedInBefore()) { | |||
There was a problem hiding this comment.
Let's remove the hasLoggedInBefore so that you are landing on the website when you've logged out.
There was a problem hiding this comment.
I just learned about the markLoggedIn which sets a HTTP cookie gitpod-user=loggedIn.
But we already have a session cookie gitpod-user=loggedIn, which is managed on login/logout.
There was a problem hiding this comment.
hasLoggedInBefore checks for a Cookie which is never removed, gitpod-user=loggedIn used to reflect the session state.
WDYT of renaming the new Cookie, so it reflects that particular state? maybe something like "gitpod-logged-in-before". Maybe we can even set the provider host as value ;-)
There was a problem hiding this comment.
The cookie should be called 'seen-gitpod' or so, as it just indicates the user knows gitpod (has seen the website or the app). Anyhow, we don't want to use it here, as the login state is enough. We really should redirect everyone to www once they are logged out.
There was a problem hiding this comment.
Anyhow, we don't want to use it here, as the login state is enough. We really should redirect everyone to www once they are logged out.
Roger that. The thing is, that the "login state" is fetched asynchronously. So, removing of the gitpod-user=loggedIn (session) cookie check, would mean that the redirect might happen in any case.
There was a problem hiding this comment.
This is what used to work before:
|
/werft run 👍 started the job as gitpod-build-at-redirect-www.8 |
| @@ -71,6 +71,12 @@ function App() { | |||
| } | |||
| }, [localStorage.theme]); | |||
|
|
|||
| if (window.location.pathname === '/' && window.location.hash === '' && !hasLoggedInBefore()) { | |||
| if (window.location.host === "gitpod.io" || window.location.host === "gitpod-staging.com") { | |||
There was a problem hiding this comment.
nit: in development the URL is https://at-redirect-www.staging.gitpod-dev.com which won't match this logic.
There was a problem hiding this comment.
true. in the dashboard component we still don't have a proper solution for the URL mismatch in preview environments.
There was a problem hiding this comment.
Maybe something like this?
| if (window.location.host === "gitpod.io" || window.location.host === "gitpod-staging.com") { | |
| if (["gitpod.io", "gitpod-staging.com", "gitpod-dev.com", "gitpod-io-dev.com"].some(suffix => window.location.host.endsWith(suffix))) { |
|
/werft run 👍 started the job as gitpod-build-at-redirect-www.9 |
|
continuing here #4070 |
in SaaS context we want to redirect not logged in users from the root URL with no additional context provided to the website URL.
fixes #3898