Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[content-service] Update cloud.google.com/go/storage dependency #3809

Merged
merged 2 commits into from
Apr 13, 2021
Merged

[content-service] Update cloud.google.com/go/storage dependency #3809

merged 2 commits into from
Apr 13, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 7, 2021

Contains several fixes and also updates google.golang.org/api to v0.40.0

@aledbf aledbf requested a review from csweichel April 7, 2021 12:03
@csweichel
Copy link
Contributor

csweichel commented Apr 7, 2021 •
edited
Loading

When I open this in PR Gitpod I get a ton of go.sum changes, virtually undoing #3791.
Do you know why that is?

@aledbf
Copy link
Member Author

aledbf commented Apr 7, 2021 •
edited
Loading

@csweichel how are you updating the dependencies?

Edit: I use leeway exec --filter-type go -v -- go mod tidy -v after updating the dependency

@csweichel
Copy link
Contributor

I reckon it's the work of the VSCode Go extension that bloats the go.sum files.

The go mod tidy run makes perfect sense, but seems to be at odds with something else in the workspace.

@aledbf aledbf force-pushed the aledbf/storagedep branch from 2d99761 to 655a67c Compare April 8, 2021 11:09
@aledbf
Copy link
Member Author

aledbf commented Apr 8, 2021

@csweichel using the latest build of the go update I don't see changes now running

https://aledbf-go163.staging.gitpod-dev.com/#https://github.com/gitpod-io/gitpod/pull/3809

@aledbf
Copy link
Member Author

aledbf commented Apr 8, 2021 •
edited
Loading

/werft run

@aledbf
Copy link
Member Author

aledbf commented Apr 8, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-storagedep.2

@aledbf
Copy link
Member Author

aledbf commented Apr 8, 2021 •
edited
Loading

@csweichel setting buildCommand broke all go lib builds. The last commit in this PR fixes that. Is there any other alternative?

fixed

@aledbf aledbf force-pushed the aledbf/storagedep branch from 7b83981 to 3da1463 Compare April 8, 2021 11:36
@aledbf aledbf force-pushed the aledbf/storagedep branch from 3da1463 to 0d281c3 Compare April 9, 2021 13:28
@aledbf aledbf mentioned this pull request Apr 9, 2021
Closed
24 tasks
@aledbf
Copy link
Member Author

aledbf commented Apr 9, 2021 •
edited
Loading

@csweichel with the updates in #3820, when you open this PR in gitpod.io, there are no file changes now.

@csweichel
Copy link
Contributor

@csweichel with the updates in #3820, when you open this PR in gitpod.io, there are no file changes now.

does that make this PR obsolete?

@aledbf
Copy link
Member Author

aledbf commented Apr 13, 2021

does that make this PR obsolete?

No. The goal of this PR is to update the storage dependency

csweichel
csweichel approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it now. Thanks for the update.

@aledbf aledbf merged commit 998c4e8 into main Apr 13, 2021
@aledbf aledbf deleted the aledbf/storagedep branch April 13, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csweichel csweichel csweichel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aledbf @csweichel