Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Don't show workspaces with zero instances as 'active' #3784

Merged
merged 1 commit into from
Apr 9, 2021
Merged

[dashboard] Don't show workspaces with zero instances as 'active' #3784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/dashboard/src/workspaces/workspace-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export class WorkspaceModel implements Disposable, Partial<GitpodClient> {

protected isActive(info: WorkspaceInfo): boolean {
return info.workspace.pinned ||
info.latestInstance?.status?.phase !== 'stopped';
(!!info.latestInstance && info.latestInstance.status?.phase !== 'stopped');
}

public getAllFetchedWorkspaces(): Map<string, WorkspaceInfo> {
Expand Down