Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Fix remaining issues in new start screen #3693

Merged
merged 12 commits into from
Apr 2, 2021

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Apr 1, 2021

Part of #3689

Fixes #3654 #3687 #3707

Errors

Screenshot 2021-04-02 at 10 28 39

Screenshot 2021-04-02 at 10 32 33

Screenshot 2021-04-01 at 17 01 56

Limit Reached

Screenshot 2021-04-02 at 10 39 42

Screenshot 2021-04-01 at 15 59 08

Stopped

Screenshot 2021-04-02 at 10 41 22

Screenshot 2021-04-02 at 10 41 35

@jankeromnes jankeromnes force-pushed the jx/remaining-start-issues branch from 7feaf5d to bbb7bd8 Compare April 1, 2021 04:40
@jankeromnes jankeromnes force-pushed the jx/remaining-start-issues branch 4 times, most recently from 5d8bbe3 to d700432 Compare April 1, 2021 08:58
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jankeromnes! Left a few minor comments. 🏓

components/dashboard/src/start/CreateWorkspace.tsx Outdated Show resolved Hide resolved
components/dashboard/src/start/StartPage.tsx Outdated Show resolved Hide resolved
components/dashboard/src/components/Modal.tsx Outdated Show resolved Hide resolved
components/dashboard/src/start/CreateWorkspace.tsx Outdated Show resolved Hide resolved
components/dashboard/src/start/CreateWorkspace.tsx Outdated Show resolved Hide resolved
@jankeromnes jankeromnes force-pushed the jx/remaining-start-issues branch 2 times, most recently from dd67eba to 16c8bdb Compare April 1, 2021 17:27
@jankeromnes jankeromnes marked this pull request as ready for review April 1, 2021 17:28
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Apr 1, 2021

Okay, this PR is getting big enough, leaving the "repo not found" differentiation as follow-up.

@gtsiolis / @svenefftinge could you please have a look? 🙏

@svenefftinge
Copy link
Member

Tried this one to test docker build failure:

Looks just stuck to me. Also would be good to have the option to start the workspace with the default image.

@svenefftinge
Copy link
Member

  • Would be great if the buttons were anchors so I can Cmd+Click them.
  • I wasn't able to reach the parallel workspace limit (started more than 16). What's the limit in the preview envs here?

Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Apr 1, 2021

Many thanks!

I wasn't able to reach the parallel workspace limit (started more than 16). What's the limit in the preview envs here?

No limit in core, I think. 4 in io/com with Free plan (see corresponding io/com deployment).

@jankeromnes jankeromnes force-pushed the jx/remaining-start-issues branch from 16c8bdb to 1e9e079 Compare April 2, 2021 06:39
@jankeromnes jankeromnes force-pushed the jx/remaining-start-issues branch from 1e9e079 to df4f52f Compare April 2, 2021 07:32
- out of hours
- too many parallel workspaces
- repository is private
- Reduce console.log() noise
- Remove showPaymentUI and clientRegion from state
- Increase pending upgrades/downgrades timeout to 5 minutes
- Offer Student Unleashed plan when user is a student
@jankeromnes jankeromnes force-pushed the jx/remaining-start-issues branch from df4f52f to 632f3c9 Compare April 2, 2021 08:16
@jankeromnes jankeromnes force-pushed the jx/remaining-start-issues branch 2 times, most recently from 7be6f33 to 871716c Compare April 2, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Center error message and button on stopping workspace page
3 participants