[dashboard] Add Git Providers #3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run 👍 started the job as gitpod-build-at-gitproviders.2 |
svenefftinge
approved these changes
Mar 22, 2021
| const clickable = e.href || e.onClick; | ||
| const entry = <div key={e.title} className={`px-4 flex py-3 ${clickable?'hover:bg-gray-200':''} text-sm leading-1 ${e.customFontStyle || font} ${e.separator? ' border-b border-gray-200':''}`} > | ||
| <div>{e.title}</div><div className="flex-1"></div>{e.active ? <div className="pl-1 font-semibold">✓</div>: null} | ||
| </div> | ||
| if (!clickable) { | ||
| return entry; | ||
| } | ||
| return <a key={e.title} href={e.href} onClick={e.onClick}> | ||
| return <a key={`entry-${menuId}-${index}-${e.title}`} href={e.href} onClick={e.onClick}> |
There was a problem hiding this comment.
Could you explain why the title wasn't sufficient here?
There was a problem hiding this comment.
when rendering a table with rows which each contain a context menu with the same title you get the "unique" key problem.
There was a problem hiding this comment.
Oh, interesting. I thought the uniqueness was only required among sibling nodes
AlexTugarev
force-pushed
the
at/gitproviders
branch
from
f0e8781 to
fdf8bb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Part 1 of #3401