[ws-daemon] Add ws-daemon headless service

[rl-gitpod]

Use endpoint on the ws-manager node to avoid pod/nodePort access issues.
Addresses #2956

[geropl]

Thx for your contribution @rl-gitpod !

Approach and implementation look good to me. @csweichel ?

[aledbf]

@rl-gitpod, why not just replace/improve/fix the current approach? Adding an option without any additional check for the CNI will lead to the same restriction and problems.

[rl-gitpod]

@rl-gitpod, why not just replace/improve/fix the current approach? Adding an option without any additional check for the CNI will lead to the same restriction and problems.

@aledbf - not sure I follow.
This replaces/fixes the current approach for ws-manager accessing ws-daemon as per #2956

I agree that there is a much bigger and potentially more impactful aspect of using the nodePort and the existing wso.HostIP() elsewhere throughout the code base - which is perhaps what you are referring to? If so, that was the thinking but beyond the scope of this issue and I'm unsure of where that fits in the short/medium term.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[aledbf]

/werft run

👍 started the job as gitpod-build-rl-2956-no-ws-daemon-nodeport.2

[aledbf]

@csweichel friendly ping

[csweichel]

/werft run

👍 started the job as gitpod-build-rl-2956-no-ws-daemon-nodeport.3

[csweichel]

/werft run

👍 started the job as gitpod-build-rl-2956-no-ws-daemon-nodeport.8

[codecov]

Codecov Report

Merging #3473 (40ec397) into main (2f7cc15) will increase coverage by 37.07%.
The diff coverage is 84.84%.

@@            Coverage Diff            @@
##           main    #3473       +/-   ##
=========================================
+ Coverage      0   37.07%   +37.07%     
=========================================
  Files         0       14       +14     
  Lines         0     3903     +3903     
=========================================
+ Hits          0     1447     +1447     
- Misses        0     2337     +2337     
- Partials      0      119      +119     

Flag	Coverage Δ
components-ws-manager-app	37.07% <84.84%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/ws-manager/pkg/manager/annotations.go	66.66% <ø> (ø)
components/ws-manager/pkg/manager/monitor.go	0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/manager.go	27.39% <88.88%> (ø)
components/ws-manager/pkg/manager/status.go	72.32% <100.00%> (ø)
...omponents/ws-manager/pkg/manager/pod_controller.go	0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/headless.go	44.00% <0.00%> (ø)
components/ws-manager/pkg/manager/imagespec.go	0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/probe.go	0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/create.go	79.40% <0.00%> (ø)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7cc15...40ec397. Read the comment docs.

[csweichel]

LGTM