[dashboard] Re-implement running workspace selector for new dashboard #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
force-pushed
the
jx/dash2-improve-start
branch
from
41ffe52 to
57cdf99
Compare
|
Currently looks like this:
|
jankeromnes
force-pushed
the
jx/dash2-improve-start
branch
from
57cdf99 to
8a2e6e2
Compare
|
Feedback from @gtsiolis on Slack:
|
jankeromnes
force-pushed
the
jx/dash2-improve-start
branch
from
8a2e6e2 to
2d8b7b9
Compare
jankeromnes
commented
Mar 16, 2021
gtsiolis
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
Thanks @jankeromnes! Great to see this come alive! Left some first comments. Padding within each workspace item still needs some small changes.
jankeromnes
force-pushed
the
jx/dash2-improve-start
branch
from
2d8b7b9 to
5df7f89
Compare
Co-authored-by: George Tsiolis <[email protected]>
jankeromnes
force-pushed
the
jx/dash2-improve-start
branch
from
5df7f89 to
4c14041
Compare
gtsiolis
reviewed
Mar 16, 2021
jankeromnes
force-pushed
the
jx/dash2-improve-start
branch
from
2e9ffa9 to
bd86ee3
Compare
gtsiolis
reviewed
Mar 16, 2021
| <div className="w-full"> | ||
| <p className="text-base text-black font-bold">{w.workspace.id}</p> | ||
| <p>{w.workspace.contextURL}</p> | ||
| </div> | ||
| <div className="flex"> | ||
| <button className="px-3 py-1 my-auto bg-green-600 hover:bg-green-700 border-green-800">Open</button> | ||
| <button className="px-3 py-1 my-auto opacity-0 group-hover:opacity-100 bg-green-600 hover:bg-green-700 border-green-800">Open</button> |
There was a problem hiding this comment.
praise: Tailwind black magic. 🔮
There was a problem hiding this comment.
Haha, thanks! I even went down the rabbit hole of configurable variants in order to try and get invisible group-hover:visible to work, but it kept refusing to. Turns out group-hover works out of the box with opacity, so I switched to that. 🤷
There was a problem hiding this comment.
DOES. THE. JOB. Let's ship this! 🚢
jankeromnes
force-pushed
the
jx/dash2-improve-start
branch
from
bd86ee3 to
a19626c
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3301