[supervisor] backoff port auto expose on deadline exceeded #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
force-pushed
the
ak/auto_expose_with_backoff
branch
from
63e3780 to
b982a27
Compare
csweichel
reviewed
Feb 5, 2021
akosyakov
force-pushed
the
ak/auto_expose_with_backoff
branch
2 times, most recently
from
270577a to
7929a2e
Compare
|
It should be good for review now. I will drop test commits and squash before merging after the review. |
csweichel
reviewed
Feb 8, 2021
akosyakov
force-pushed
the
ak/auto_expose_with_backoff
branch
4 times, most recently
from
d5cd263 to
fc1f98e
Compare
akosyakov
force-pushed
the
ak/auto_expose_with_backoff
branch
from
fc1f98e to
4128b45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Right now we are trying to auto expose ports each 5s from the supervisor. This PR implements the backoff with 1.5 factor up to half a minute delay.
How to test
In logs, you should see that first port gets exposed immediately. For the second port you should see many retries with 1.5 factor and after 1m it gets exposed too.