Lauch Dockerd when opening a Gitpod Workspace on this Repo #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meysholdt
changed the title
csweichel
reviewed
Dec 2, 2020
| @@ -34,6 +34,15 @@ tasks: | |||
| - name: Go | |||
| init: leeway exec --filter-type go -v -- go get -v ./... | |||
| openMode: split-right | |||
| - name: Docker | |||
| command: | | |||
| if [ -x "$(which docker-up)" ] | |||
There was a problem hiding this comment.
I had a bit more of a think about this. While it's true that docker-up is only in the path if feature preview is enabled, that's because feature preview also enables registry-facade. Hence which docker-up is more of a signal for registry facade rather than user namespaces.
Also, in gitpod-io it's likely to have docker-up in the path even without registry-facade due to the go get ... in components/docker-up.
Instead you could check if sudo works, e.g.
if [ sudo true &>/dev/null ]; then
sudo docker-up
else
echo "Enable 'Feature Preview' in your Gitpod profile for Docker support."
fi
|
superseded by #4018 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this,
docker buildanddocker runwill just work in a fresh workspace.