Enable collaborators #20353
Enable collaborators #20353
Conversation
| @@ -92,7 +92,7 @@ schema: |- | |||
| permission read_billing = member + owner + installation->admin | |||
| permission write_billing = owner + installation->admin | |||
|
|
|||
| permission read_prebuild = member + owner + installation->admin | |||
| permission read_prebuild = collaborator + member + owner + installation->admin | |||
There was a problem hiding this comment.
This org-wide read prebuild permission I flipped on accidentally when looking for the project-specific one, and it ended up raising a question: do we want to let collaborators view the list of prebuilds of the org? I'm guessing not, because we'd have to change those the related pages quite a bit (to signal that you can't start / stop prebuilds or view any of their settings), but it very theoretically could be useful if they wanted to at check what's wrong with a repo's prebuild config and if it's something they can fix themselves.
The detail of a single prebuild still will need some small tweaks to be properly accessible (currently, it just errors), but it probably wouldn't take too long to change.
| @@ -128,15 +128,12 @@ export function deduplicateAndFilterRepositories( | |||
| if (results.length === 0) { | |||
| // If the searchString is a URL, and it's not present in the proposed results, "artificially" add it here. | |||
| if (isValidGitUrl(searchString)) { | |||
| console.log("It's valid man"); | |||
There was a problem hiding this comment.
These super rad debug logs I accidentally left in with #20287. Yikes!
| ); | ||
| // todo(ft): solve for this case with collaborators who can't select projects directly |
There was a problem hiding this comment.
I'd love ideas around this: how can we not block collaborators if a repo they're working on gets imported twice? Or, in the very least, how do we educate members and owners about this possibility?
It's admittedly a case on the edge™, but IMO worth considering.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
meta: stale
Description
Makes the following changes to the Collaborator role:
To be merged sometime around November 25th to give users a heads-up.
Related Issue(s)
Fixes CLC-815
How to test
HELLO_VARIABLES) and it should be prebuilt.Documentation
This does require documentation changes. I will work on those as we get closer to the merge date
/hold