Fix dev settings link for git providers #17714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtsiolis
approved these changes
May 23, 2023
There was a problem hiding this comment.
Thanks, @selfcontained. 🌮 🌮
Left some non-blocking comments. Should be ok to merge this as is, too.
components/dashboard/src/teams/git-integrations/GitIntegrationModal.tsx
Outdated
Show resolved
Hide resolved
components/dashboard/src/teams/git-integrations/GitIntegrationModal.tsx
Outdated
Show resolved
Hide resolved
components/dashboard/src/teams/git-integrations/GitIntegrationModal.tsx
Outdated
Show resolved
Hide resolved
svenefftinge
approved these changes
May 24, 2023
|
/unhold |
roboquat
deleted the
brad/web-327-the-developer-settings-link-in-the-help-text-when-adding-a
branch
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the user hasn’t entered a host value yet in the form, our links are broken as described in the issue.
I’ve opted to have the links default to github.com and gitlab.com when there’s no custom host entered in the form yet, but once there is, the links will use that host.After some discussion, we'll simplify this view so the hint text links below the input aren't dynamic, and we just link to the corresponding GitLab or GitHub docs.
Related Issue(s)
Fixes WEB-327
How to test
New Git ProviderRedirect URIinput matches the images above.Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold