[rebuild] auto manage windows #16561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csweichel
approved these changes
Feb 24, 2023
akosyakov
commented
Feb 24, 2023
| @@ -262,6 +267,11 @@ LoadingFrame.load().then(async (loading) => { | |||
| }); | |||
| } | |||
| const supervisorServiceClient = SupervisorServiceClient.get(); | |||
| if (debugWorkspace) { | |||
| supervisorServiceClient.supervisorWillShutdown.then(() => { | |||
There was a problem hiding this comment.
(off-topic) just thinking, but with this event, we won't need anymore to know the status phase, i.e
- when supervisorReady then show IDE instead of the loading screen
- when supervisorWIllShutdown show the loading screen instead of IDE
and instance id we can get from info endpoint already?
akosyakov
force-pushed
the
ak/auto_windows
branch
from
010e3f0 to
dad0a90
Compare
akosyakov
changed the title
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #16535 for the motivation and loom for demo.
Related Issue(s)
fix #16535
How to test
From sources
components/supervisor/validate.shRelease Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh